Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Unified Diff: Source/bindings/tests/results/V8TestSpecialOperationsIdentifierRaisesException.cpp

Issue 158663002: IDL compiler: sync Python to r166688 (and clean up special operations+union code) (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Typo Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/tests/results/V8TestSpecialOperationsIdentifierRaisesException.cpp
diff --git a/Source/bindings/tests/results/V8TestSpecialOperationsIdentifierRaisesException.cpp b/Source/bindings/tests/results/V8TestSpecialOperationsIdentifierRaisesException.cpp
index 457a804466564a428903ad69c330f7ceb877ed91..90158c289587860d1679d97df2e17c2c3c351b38 100644
--- a/Source/bindings/tests/results/V8TestSpecialOperationsIdentifierRaisesException.cpp
+++ b/Source/bindings/tests/results/V8TestSpecialOperationsIdentifierRaisesException.cpp
@@ -214,14 +214,14 @@ static void deleteNamedItemMethodCallback(const v8::FunctionCallbackInfo<v8::Val
static void indexedPropertyGetter(uint32_t index, const v8::PropertyCallbackInfo<v8::Value>& info)
{
- TestSpecialOperationsIdentifierRaisesException* collection = V8TestSpecialOperationsIdentifierRaisesException::toNative(info.Holder());
+ TestSpecialOperationsIdentifierRaisesException* imp = V8TestSpecialOperationsIdentifierRaisesException::toNative(info.Holder());
ExceptionState exceptionState(info.Holder(), info.GetIsolate());
- RefPtr<TestInterfaceEmpty> element = collection->item(index, exceptionState);
+ RefPtr<TestInterfaceEmpty> result = imp->item(index, exceptionState);
if (exceptionState.throwIfNeeded())
return;
- if (!element)
+ if (!result)
return;
- v8SetReturnValueFast(info, element.release(), collection);
+ v8SetReturnValueFast(info, result.release(), imp);
}
static void indexedPropertyGetterCallback(uint32_t index, const v8::PropertyCallbackInfo<v8::Value>& info)
@@ -233,10 +233,10 @@ static void indexedPropertyGetterCallback(uint32_t index, const v8::PropertyCall
static void indexedPropertySetter(uint32_t index, v8::Local<v8::Value> jsValue, const v8::PropertyCallbackInfo<v8::Value>& info)
{
- TestSpecialOperationsIdentifierRaisesException* collection = V8TestSpecialOperationsIdentifierRaisesException::toNative(info.Holder());
+ TestSpecialOperationsIdentifierRaisesException* imp = V8TestSpecialOperationsIdentifierRaisesException::toNative(info.Holder());
V8TRYCATCH_FOR_V8STRINGRESOURCE_VOID(V8StringResource<>, propertyValue, jsValue);
ExceptionState exceptionState(info.Holder(), info.GetIsolate());
- bool result = collection->setItem(index, propertyValue, exceptionState);
+ bool result = imp->setItem(index, propertyValue, exceptionState);
if (exceptionState.throwIfNeeded())
return;
if (!result)
@@ -253,9 +253,9 @@ static void indexedPropertySetterCallback(uint32_t index, v8::Local<v8::Value> j
static void indexedPropertyDeleter(uint32_t index, const v8::PropertyCallbackInfo<v8::Boolean>& info)
{
- TestSpecialOperationsIdentifierRaisesException* collection = V8TestSpecialOperationsIdentifierRaisesException::toNative(info.Holder());
+ TestSpecialOperationsIdentifierRaisesException* imp = V8TestSpecialOperationsIdentifierRaisesException::toNative(info.Holder());
ExceptionState exceptionState(info.Holder(), info.GetIsolate());
- DeleteResult result = collection->deleteItem(index, exceptionState);
+ DeleteResult result = imp->deleteItem(index, exceptionState);
if (exceptionState.throwIfNeeded())
return;
if (result != DeleteUnknownProperty)
@@ -278,15 +278,15 @@ static void namedPropertyGetter(v8::Local<v8::String> name, const v8::PropertyCa
if (info.Holder()->HasRealNamedProperty(name))
return;
- TestSpecialOperationsIdentifierRaisesException* collection = V8TestSpecialOperationsIdentifierRaisesException::toNative(info.Holder());
+ TestSpecialOperationsIdentifierRaisesException* imp = V8TestSpecialOperationsIdentifierRaisesException::toNative(info.Holder());
AtomicString propertyName = toCoreAtomicString(name);
ExceptionState exceptionState(info.Holder(), info.GetIsolate());
- RefPtr<TestInterfaceEmpty> element = collection->namedItem(propertyName, exceptionState);
+ RefPtr<TestInterfaceEmpty> result = imp->namedItem(propertyName, exceptionState);
if (exceptionState.throwIfNeeded())
return;
- if (!element)
+ if (!result)
return;
- v8SetReturnValueFast(info, element.release(), collection);
+ v8SetReturnValueFast(info, result.release(), imp);
}
static void namedPropertyGetterCallback(v8::Local<v8::String> name, const v8::PropertyCallbackInfo<v8::Value>& info)
@@ -305,11 +305,11 @@ static void namedPropertySetter(v8::Local<v8::String> name, v8::Local<v8::Value>
if (info.Holder()->HasRealNamedProperty(name))
return;
- TestSpecialOperationsIdentifierRaisesException* collection = V8TestSpecialOperationsIdentifierRaisesException::toNative(info.Holder());
+ TestSpecialOperationsIdentifierRaisesException* imp = V8TestSpecialOperationsIdentifierRaisesException::toNative(info.Holder());
V8TRYCATCH_FOR_V8STRINGRESOURCE_VOID(V8StringResource<>, propertyName, name);
V8TRYCATCH_FOR_V8STRINGRESOURCE_VOID(V8StringResource<>, propertyValue, jsValue);
ExceptionState exceptionState(info.Holder(), info.GetIsolate());
- bool result = collection->setNamedItem(propertyName, propertyValue, exceptionState);
+ bool result = imp->setNamedItem(propertyName, propertyValue, exceptionState);
if (exceptionState.throwIfNeeded())
return;
if (!result)
@@ -326,10 +326,10 @@ static void namedPropertySetterCallback(v8::Local<v8::String> name, v8::Local<v8
static void namedPropertyQuery(v8::Local<v8::String> name, const v8::PropertyCallbackInfo<v8::Integer>& info)
{
- TestSpecialOperationsIdentifierRaisesException* collection = V8TestSpecialOperationsIdentifierRaisesException::toNative(info.Holder());
+ TestSpecialOperationsIdentifierRaisesException* imp = V8TestSpecialOperationsIdentifierRaisesException::toNative(info.Holder());
AtomicString propertyName = toCoreAtomicString(name);
ExceptionState exceptionState(info.Holder(), info.GetIsolate());
- bool result = collection->namedPropertyQuery(propertyName, exceptionState);
+ bool result = imp->namedPropertyQuery(propertyName, exceptionState);
if (exceptionState.throwIfNeeded())
return;
if (!result)
@@ -346,10 +346,10 @@ static void namedPropertyQueryCallback(v8::Local<v8::String> name, const v8::Pro
static void namedPropertyDeleter(v8::Local<v8::String> name, const v8::PropertyCallbackInfo<v8::Boolean>& info)
{
- TestSpecialOperationsIdentifierRaisesException* collection = V8TestSpecialOperationsIdentifierRaisesException::toNative(info.Holder());
+ TestSpecialOperationsIdentifierRaisesException* imp = V8TestSpecialOperationsIdentifierRaisesException::toNative(info.Holder());
AtomicString propertyName = toCoreAtomicString(name);
ExceptionState exceptionState(info.Holder(), info.GetIsolate());
- DeleteResult result = collection->deleteNamedItem(propertyName, exceptionState);
+ DeleteResult result = imp->deleteNamedItem(propertyName, exceptionState);
if (exceptionState.throwIfNeeded())
return;
if (result != DeleteUnknownProperty)
@@ -365,10 +365,10 @@ static void namedPropertyDeleterCallback(v8::Local<v8::String> name, const v8::P
static void namedPropertyEnumerator(const v8::PropertyCallbackInfo<v8::Array>& info)
{
- TestSpecialOperationsIdentifierRaisesException* collection = V8TestSpecialOperationsIdentifierRaisesException::toNative(info.Holder());
+ TestSpecialOperationsIdentifierRaisesException* imp = V8TestSpecialOperationsIdentifierRaisesException::toNative(info.Holder());
Vector<String> names;
ExceptionState exceptionState(info.Holder(), info.GetIsolate());
- collection->namedPropertyEnumerator(names, exceptionState);
+ imp->namedPropertyEnumerator(names, exceptionState);
if (exceptionState.throwIfNeeded())
return;
v8::Handle<v8::Array> v8names = v8::Array::New(info.GetIsolate(), names.size());

Powered by Google App Engine
This is Rietveld 408576698