Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Unified Diff: Source/bindings/tests/results/V8TestSpecialOperationsAnonymous.cpp

Issue 158663002: IDL compiler: sync Python to r166688 (and clean up special operations+union code) (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Typo Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/tests/results/V8TestSpecialOperationsAnonymous.cpp
diff --git a/Source/bindings/tests/results/V8TestSpecialOperationsAnonymous.cpp b/Source/bindings/tests/results/V8TestSpecialOperationsAnonymous.cpp
index c4ace33badbc3e5b5b2ea4489e9eab5785c2bd0e..e41e918c521d121e84451151f3d9cc4376304fcf 100644
--- a/Source/bindings/tests/results/V8TestSpecialOperationsAnonymous.cpp
+++ b/Source/bindings/tests/results/V8TestSpecialOperationsAnonymous.cpp
@@ -73,11 +73,11 @@ template <typename T> void V8_USE(T) { }
static void indexedPropertyGetter(uint32_t index, const v8::PropertyCallbackInfo<v8::Value>& info)
{
- TestSpecialOperationsAnonymous* collection = V8TestSpecialOperationsAnonymous::toNative(info.Holder());
- String element = collection->anonymousIndexedGetter(index);
- if (element.isNull())
+ TestSpecialOperationsAnonymous* imp = V8TestSpecialOperationsAnonymous::toNative(info.Holder());
+ String result = imp->anonymousIndexedGetter(index);
+ if (result.isNull())
return;
- v8SetReturnValueString(info, element, info.GetIsolate());
+ v8SetReturnValueString(info, result, info.GetIsolate());
}
static void indexedPropertyGetterCallback(uint32_t index, const v8::PropertyCallbackInfo<v8::Value>& info)
@@ -89,9 +89,9 @@ static void indexedPropertyGetterCallback(uint32_t index, const v8::PropertyCall
static void indexedPropertySetter(uint32_t index, v8::Local<v8::Value> jsValue, const v8::PropertyCallbackInfo<v8::Value>& info)
{
- TestSpecialOperationsAnonymous* collection = V8TestSpecialOperationsAnonymous::toNative(info.Holder());
+ TestSpecialOperationsAnonymous* imp = V8TestSpecialOperationsAnonymous::toNative(info.Holder());
V8TRYCATCH_FOR_V8STRINGRESOURCE_VOID(V8StringResource<>, propertyValue, jsValue);
- bool result = collection->anonymousIndexedSetter(index, propertyValue);
+ bool result = imp->anonymousIndexedSetter(index, propertyValue);
if (!result)
return;
v8SetReturnValue(info, jsValue);
@@ -106,8 +106,8 @@ static void indexedPropertySetterCallback(uint32_t index, v8::Local<v8::Value> j
static void indexedPropertyDeleter(uint32_t index, const v8::PropertyCallbackInfo<v8::Boolean>& info)
{
- TestSpecialOperationsAnonymous* collection = V8TestSpecialOperationsAnonymous::toNative(info.Holder());
- DeleteResult result = collection->anonymousIndexedDeleter(index);
+ TestSpecialOperationsAnonymous* imp = V8TestSpecialOperationsAnonymous::toNative(info.Holder());
+ DeleteResult result = imp->anonymousIndexedDeleter(index);
if (result != DeleteUnknownProperty)
return v8SetReturnValueBool(info, result == DeleteSuccess);
}
@@ -128,12 +128,12 @@ static void namedPropertyGetter(v8::Local<v8::String> name, const v8::PropertyCa
if (info.Holder()->HasRealNamedProperty(name))
return;
- TestSpecialOperationsAnonymous* collection = V8TestSpecialOperationsAnonymous::toNative(info.Holder());
+ TestSpecialOperationsAnonymous* imp = V8TestSpecialOperationsAnonymous::toNative(info.Holder());
AtomicString propertyName = toCoreAtomicString(name);
- String element = collection->anonymousNamedGetter(propertyName);
- if (element.isNull())
+ String result = imp->anonymousNamedGetter(propertyName);
+ if (result.isNull())
return;
- v8SetReturnValueString(info, element, info.GetIsolate());
+ v8SetReturnValueString(info, result, info.GetIsolate());
}
static void namedPropertyGetterCallback(v8::Local<v8::String> name, const v8::PropertyCallbackInfo<v8::Value>& info)
@@ -152,10 +152,10 @@ static void namedPropertySetter(v8::Local<v8::String> name, v8::Local<v8::Value>
if (info.Holder()->HasRealNamedProperty(name))
return;
- TestSpecialOperationsAnonymous* collection = V8TestSpecialOperationsAnonymous::toNative(info.Holder());
+ TestSpecialOperationsAnonymous* imp = V8TestSpecialOperationsAnonymous::toNative(info.Holder());
V8TRYCATCH_FOR_V8STRINGRESOURCE_VOID(V8StringResource<>, propertyName, name);
V8TRYCATCH_FOR_V8STRINGRESOURCE_VOID(V8StringResource<>, propertyValue, jsValue);
- bool result = collection->anonymousNamedSetter(propertyName, propertyValue);
+ bool result = imp->anonymousNamedSetter(propertyName, propertyValue);
if (!result)
return;
v8SetReturnValue(info, jsValue);
@@ -170,10 +170,10 @@ static void namedPropertySetterCallback(v8::Local<v8::String> name, v8::Local<v8
static void namedPropertyQuery(v8::Local<v8::String> name, const v8::PropertyCallbackInfo<v8::Integer>& info)
{
- TestSpecialOperationsAnonymous* collection = V8TestSpecialOperationsAnonymous::toNative(info.Holder());
+ TestSpecialOperationsAnonymous* imp = V8TestSpecialOperationsAnonymous::toNative(info.Holder());
AtomicString propertyName = toCoreAtomicString(name);
ExceptionState exceptionState(info.Holder(), info.GetIsolate());
- bool result = collection->namedPropertyQuery(propertyName, exceptionState);
+ bool result = imp->namedPropertyQuery(propertyName, exceptionState);
if (exceptionState.throwIfNeeded())
return;
if (!result)
@@ -190,9 +190,9 @@ static void namedPropertyQueryCallback(v8::Local<v8::String> name, const v8::Pro
static void namedPropertyDeleter(v8::Local<v8::String> name, const v8::PropertyCallbackInfo<v8::Boolean>& info)
{
- TestSpecialOperationsAnonymous* collection = V8TestSpecialOperationsAnonymous::toNative(info.Holder());
+ TestSpecialOperationsAnonymous* imp = V8TestSpecialOperationsAnonymous::toNative(info.Holder());
AtomicString propertyName = toCoreAtomicString(name);
- DeleteResult result = collection->anonymousNamedDeleter(propertyName);
+ DeleteResult result = imp->anonymousNamedDeleter(propertyName);
if (result != DeleteUnknownProperty)
return v8SetReturnValueBool(info, result == DeleteSuccess);
}
@@ -206,10 +206,10 @@ static void namedPropertyDeleterCallback(v8::Local<v8::String> name, const v8::P
static void namedPropertyEnumerator(const v8::PropertyCallbackInfo<v8::Array>& info)
{
- TestSpecialOperationsAnonymous* collection = V8TestSpecialOperationsAnonymous::toNative(info.Holder());
+ TestSpecialOperationsAnonymous* imp = V8TestSpecialOperationsAnonymous::toNative(info.Holder());
Vector<String> names;
ExceptionState exceptionState(info.Holder(), info.GetIsolate());
- collection->namedPropertyEnumerator(names, exceptionState);
+ imp->namedPropertyEnumerator(names, exceptionState);
if (exceptionState.throwIfNeeded())
return;
v8::Handle<v8::Array> v8names = v8::Array::New(info.GetIsolate(), names.size());

Powered by Google App Engine
This is Rietveld 408576698