Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1185)

Issue 1585843007: Subzero. RAII NaCl Bundling. (Closed)

Created:
4 years, 11 months ago by John
Modified:
4 years, 11 months ago
Reviewers:
sehr, Karl, Jim Stichnoth
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Subzero. RAII NaCl Bundling. This CL introduces the TargetLowering::AutoBundle type, which allows RAII-style bundle emission. As part of the CL, all of the uses of TargetLowering::_bundle_lock(), and TargetLowering::_bundle_unlock(), were replaced with uses of the newly introduced type. BUG= R=sehr@chromium.org, stichnot@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=3bf335f6dc901cb71ae9a6eaf7c2dd9024719c47

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+128 lines, -87 lines) Patch
M src/IceTargetLowering.h View 2 chunks +36 lines, -5 lines 0 comments Download
M src/IceTargetLowering.cpp View 1 chunk +19 lines, -0 lines 0 comments Download
M src/IceTargetLoweringARM32.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/IceTargetLoweringARM32.cpp View 2 chunks +2 lines, -11 lines 0 comments Download
M src/IceTargetLoweringX8632.cpp View 3 chunks +25 lines, -18 lines 0 comments Download
M src/IceTargetLoweringX8664.cpp View 12 chunks +42 lines, -47 lines 0 comments Download
M src/IceTargetLoweringX86Base.h View 2 chunks +3 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
John
4 years, 11 months ago (2016-01-14 23:19:01 UTC) #2
sehr
Nice job. LGTM!
4 years, 11 months ago (2016-01-15 16:38:12 UTC) #3
Jim Stichnoth
lgtm
4 years, 11 months ago (2016-01-15 16:47:59 UTC) #4
John
4 years, 11 months ago (2016-01-15 19:18:00 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3bf335f6dc901cb71ae9a6eaf7c2dd9024719c47 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698