Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Unified Diff: src/IceTargetLoweringX86Base.h

Issue 1585843007: Subzero. RAII NaCl Bundling. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/IceTargetLoweringX8664.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/IceTargetLoweringX86Base.h
diff --git a/src/IceTargetLoweringX86Base.h b/src/IceTargetLoweringX86Base.h
index 76e1445972a072168162bb20f95ed2b50c8f3c5c..4763f63fe95f476654020781a73e3b9635c419e7 100644
--- a/src/IceTargetLoweringX86Base.h
+++ b/src/IceTargetLoweringX86Base.h
@@ -382,6 +382,7 @@ protected:
X86OperandMem **findMemoryReference() { return nullptr; }
public:
+ std::unique_ptr<AutoBundle> Bundler;
X86OperandMem **const MemOperand;
template <typename... T>
@@ -392,16 +393,12 @@ protected:
? nullptr
: findMemoryReference(Args...)) {
if (MemOperand != nullptr) {
- Target->_bundle_lock(BundleLockOpt);
+ Bundler = makeUnique<AutoBundle>(Target, BundleLockOpt);
*MemOperand = Target->_sandbox_mem_reference(*MemOperand);
}
}
- ~AutoMemorySandboxer() {
- if (MemOperand != nullptr) {
- Target->_bundle_unlock();
- }
- }
+ ~AutoMemorySandboxer() {}
};
/// The following are helpers that insert lowered x86 instructions with
« no previous file with comments | « src/IceTargetLoweringX8664.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698