Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 1578723002: [turbofan] Build s/NULL/nullptr/g and CHECK(x != nullptr) to CHECK_NOT_NULL(x). (Closed)

Created:
4 years, 11 months ago by titzer
Modified:
4 years, 11 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Change NULL to nullptr and CHECK(x != nullptr) to CHECK_NOT_NULL(x). R=bmeurer@chromium.org BUG= Committed: https://crrev.com/3ae141c121b797e15fb8cb9721dc80a17547da3f Cr-Commit-Position: refs/heads/master@{#33202}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+339 lines, -328 lines) Patch
M src/compiler/arm/code-generator-arm.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/compiler/arm/instruction-selector-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/arm64/code-generator-arm64.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/compiler/arm64/instruction-selector-arm64.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler/ast-graph-builder.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/compiler/ast-graph-builder.cc View 22 chunks +24 lines, -24 lines 0 comments Download
M src/compiler/ast-loop-assignment-analyzer.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/compiler/ast-loop-assignment-analyzer.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/bytecode-graph-builder.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/bytecode-graph-builder.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/coalesced-live-ranges.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/coalesced-live-ranges.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/code-generator.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/control-builders.h View 6 chunks +15 lines, -15 lines 0 comments Download
M src/compiler/control-equivalence.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/compiler/frame.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler/frame.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler/graph-reducer.h View 2 chunks +3 lines, -2 lines 0 comments Download
M src/compiler/graph-visualizer.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler/graph-visualizer.cc View 11 chunks +12 lines, -12 lines 0 comments Download
M src/compiler/ia32/code-generator-ia32.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/compiler/ia32/instruction-selector-ia32.cc View 8 chunks +16 lines, -15 lines 0 comments Download
M src/compiler/instruction.h View 4 chunks +6 lines, -6 lines 0 comments Download
M src/compiler/instruction.cc View 9 chunks +9 lines, -9 lines 0 comments Download
M src/compiler/instruction-selector.h View 1 chunk +8 lines, -8 lines 0 comments Download
M src/compiler/instruction-selector.cc View 10 chunks +12 lines, -12 lines 0 comments Download
M src/compiler/js-graph.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M src/compiler/js-typed-lowering.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/linkage.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/compiler/loop-analysis.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/machine-operator-reducer.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M src/compiler/mips/code-generator-mips.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M src/compiler/mips/instruction-selector-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/mips64/code-generator-mips64.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M src/compiler/mips64/instruction-selector-mips64.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler/move-optimizer.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/node.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler/node-cache.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/compiler/node-matchers.h View 4 chunks +13 lines, -13 lines 0 comments Download
M src/compiler/node-properties.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/pipeline.cc View 12 chunks +15 lines, -14 lines 0 comments Download
M src/compiler/pipeline-statistics.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler/pipeline-statistics.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M src/compiler/ppc/code-generator-ppc.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/compiler/ppc/instruction-selector-ppc.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler/raw-machine-assembler.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/compiler/register-allocator.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler/representation-change.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/compiler/schedule.h View 2 chunks +3 lines, -3 lines 0 comments Download
M src/compiler/schedule.cc View 6 chunks +7 lines, -7 lines 0 comments Download
M src/compiler/scheduler.cc View 28 chunks +50 lines, -46 lines 0 comments Download
M src/compiler/simplified-lowering.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/verifier.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M src/compiler/x64/code-generator-x64.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/compiler/x64/instruction-selector-x64.cc View 9 chunks +16 lines, -15 lines 0 comments Download
M src/compiler/x87/code-generator-x87.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/compiler/x87/instruction-selector-x87.cc View 21 chunks +33 lines, -32 lines 0 comments Download
M src/compiler/zone-pool.h View 1 chunk +5 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
titzer
4 years, 11 months ago (2016-01-11 11:00:01 UTC) #1
Benedikt Meurer
LGTM.
4 years, 11 months ago (2016-01-11 11:17:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1578723002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1578723002/20001
4 years, 11 months ago (2016-01-11 11:37:17 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-11 12:56:54 UTC) #7
commit-bot: I haz the power
4 years, 11 months ago (2016-01-11 12:57:10 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3ae141c121b797e15fb8cb9721dc80a17547da3f
Cr-Commit-Position: refs/heads/master@{#33202}

Powered by Google App Engine
This is Rietveld 408576698