Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Side by Side Diff: src/compiler/js-typed-lowering.cc

Issue 1578723002: [turbofan] Build s/NULL/nullptr/g and CHECK(x != nullptr) to CHECK_NOT_NULL(x). (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/compiler/js-graph.cc ('k') | src/compiler/linkage.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/code-factory.h" 5 #include "src/code-factory.h"
6 #include "src/compilation-dependencies.h" 6 #include "src/compilation-dependencies.h"
7 #include "src/compiler/access-builder.h" 7 #include "src/compiler/access-builder.h"
8 #include "src/compiler/js-graph.h" 8 #include "src/compiler/js-graph.h"
9 #include "src/compiler/js-typed-lowering.h" 9 #include "src/compiler/js-typed-lowering.h"
10 #include "src/compiler/linkage.h" 10 #include "src/compiler/linkage.h"
(...skipping 1253 matching lines...) Expand 10 before | Expand all | Expand 10 after
1264 effect = graph()->NewNode(common()->EffectPhi(3), 1264 effect = graph()->NewNode(common()->EffectPhi(3),
1265 bool_result_runtime_has_in_proto_chain_case, 1265 bool_result_runtime_has_in_proto_chain_case,
1266 e_eq_proto, e_null_proto, control); 1266 e_eq_proto, e_null_proto, control);
1267 1267
1268 Node* result = graph()->NewNode( 1268 Node* result = graph()->NewNode(
1269 common()->Phi(MachineRepresentation::kTagged, 3), 1269 common()->Phi(MachineRepresentation::kTagged, 3),
1270 bool_result_runtime_has_in_proto_chain_case, jsgraph()->TrueConstant(), 1270 bool_result_runtime_has_in_proto_chain_case, jsgraph()->TrueConstant(),
1271 jsgraph()->FalseConstant(), control); 1271 jsgraph()->FalseConstant(), control);
1272 1272
1273 if (if_is_smi != nullptr) { 1273 if (if_is_smi != nullptr) {
1274 DCHECK(e_is_smi != nullptr); 1274 DCHECK_NOT_NULL(e_is_smi);
1275 control = graph()->NewNode(common()->Merge(2), if_is_smi, control); 1275 control = graph()->NewNode(common()->Merge(2), if_is_smi, control);
1276 effect = 1276 effect =
1277 graph()->NewNode(common()->EffectPhi(2), e_is_smi, effect, control); 1277 graph()->NewNode(common()->EffectPhi(2), e_is_smi, effect, control);
1278 result = graph()->NewNode(common()->Phi(MachineRepresentation::kTagged, 2), 1278 result = graph()->NewNode(common()->Phi(MachineRepresentation::kTagged, 2),
1279 jsgraph()->FalseConstant(), result, control); 1279 jsgraph()->FalseConstant(), result, control);
1280 } 1280 }
1281 1281
1282 ReplaceWithValue(node, result, effect, control); 1282 ReplaceWithValue(node, result, effect, control);
1283 return Changed(result); 1283 return Changed(result);
1284 } 1284 }
(...skipping 1567 matching lines...) Expand 10 before | Expand all | Expand 10 after
2852 } 2852 }
2853 2853
2854 2854
2855 CompilationDependencies* JSTypedLowering::dependencies() const { 2855 CompilationDependencies* JSTypedLowering::dependencies() const {
2856 return dependencies_; 2856 return dependencies_;
2857 } 2857 }
2858 2858
2859 } // namespace compiler 2859 } // namespace compiler
2860 } // namespace internal 2860 } // namespace internal
2861 } // namespace v8 2861 } // namespace v8
OLDNEW
« no previous file with comments | « src/compiler/js-graph.cc ('k') | src/compiler/linkage.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698