src/compiler/move-optimizer.cc - Issue 1578723002: [turbofan] Build s/NULL/nullptr/g and CHECK(x != nullptr) to CHECK_NOT_NULL(x).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/move-optimizer.cc

Issue 1578723002: [turbofan] Build s/NULL/nullptr/g and CHECK(x != nullptr) to CHECK_NOT_NULL(x). (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/compiler/move-optimizer.cc

diff --git a/src/compiler/move-optimizer.cc b/src/compiler/move-optimizer.cc

index c81766ed0b13cac20245b421be0e042904396c80..bde3f7fe36f8a1e4e0975f6c3bba4799e56c1c87 100644

--- a/src/compiler/move-optimizer.cc

+++ b/src/compiler/move-optimizer.cc

@@ -255,7 +255,7 @@ void MoveOptimizer::OptimizeMerge(InstructionBlock* block) {

if (!GapsCanMoveOver(instr, local_zone()) || !instr->AreMovesRedundant())

break;

}

- DCHECK(instr != nullptr);

+ DCHECK_NOT_NULL(instr);

bool gap_initialized = true;

if (instr->parallel_moves()[0] == nullptr ||

instr->parallel_moves()[0]->empty()) {

« no previous file with comments | « src/compiler/mips64/instruction-selector-mips64.cc ('k') | src/compiler/node.cc » ('j') | no next file with comments »