Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(791)

Issue 15745014: Move GPU device/driver info related code from content to gpu. (Closed)

Created:
7 years, 7 months ago by Zhenyao Mo
Modified:
7 years, 7 months ago
CC:
chromium-reviews, MAD, jar (doing other things), estade+watch_chromium.org, benquan, jam, ahutter, browser-components-watch_chromium.org, dbeam+watch-autofill_chromium.org, apatrick_chromium, joi+watch-content_chromium.org, Aaron Boodman, darin-cc_chromium.org, sail+watch_chromium.org, dyu1, Albert Bodenhamer, Raman Kakilate, chromium-apps-reviews_chromium.org, Ilya Sherman, Dane Wallinga
Visibility:
Public.

Description

Move GPU device/driver info related code from content to gpu. Try to reland r201380 with build fix. This has been suggested by gman, and agreed by kbr and jam, for the following reasons: 1) These are gpu related code, and are independent of content / browser, so putting them under gpu/ is the right thing to do conceptually. 2) This enables us to set up tests in various places with the correct blacklisting/driver_bug_workarounds information. Otherwise, for the moment, gpu/ has no visibility into content/ side, so we have to duplicate the driver_bug_workarounds code and hardwire them for testing purpose. This is going to cause a lot of bugs in the future, as we have the two pieces of code for the same thing (one for chrome and one for testing) and people will easily forget to update one or the other. As for this patch, I didn't change the logic, and try to minimize the refactoring. All improvements enabled by this relocation will be done in follow-up CLs. BUG=230477 TEST=tree TBR=apatrick@chromium.org, joi@chromium.org, kbr@chromium.org, piman@chromium.org, sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=201875

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+800 lines, -9170 lines) Patch
M ash/DEPS View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M ash/shell.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/component_updater/swiftshader_component_installer.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/webstore_private/webstore_private_api.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/webstore_private/webstore_private_apitest.cc View 1 2 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/extensions/extension_service_unittest.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/requirements_checker.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/requirements_checker_browsertest.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/gpu/gpu_feature_checker.h View 1 2 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/gpu/gpu_feature_checker.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/metrics/metrics_log.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/flash_ui.cc View 1 2 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/common/child_process_logging.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/child_process_logging_mac.mm View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/common/child_process_logging_posix.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/child_process_logging_win.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/chrome_content_client.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/chrome_content_client.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/chrome_content_client_ios.mm View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/gpu/gpu_feature_browsertest.cc View 1 2 11 chunks +12 lines, -12 lines 0 comments Download
M components/autofill/browser/DEPS View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M components/autofill/browser/risk/fingerprint.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/gamepad/gamepad_platform_data_fetcher_win.cc View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M content/browser/gpu/browser_gpu_channel_host_factory.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/gpu/browser_gpu_channel_host_factory.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/browser/gpu/compositor_util.cc View 1 2 3 chunks +4 lines, -3 lines 0 comments Download
D content/browser/gpu/gpu_blacklist.h View 1 2 1 chunk +0 lines, -28 lines 0 comments Download
D content/browser/gpu/gpu_blacklist.cc View 1 2 1 chunk +0 lines, -51 lines 0 comments Download
D content/browser/gpu/gpu_blacklist_unittest.cc View 1 2 1 chunk +0 lines, -143 lines 0 comments Download
D content/browser/gpu/gpu_control_list.h View 1 2 1 chunk +0 lines, -498 lines 0 comments Download
D content/browser/gpu/gpu_control_list.cc View 1 2 1 chunk +0 lines, -1415 lines 0 comments Download
D content/browser/gpu/gpu_control_list_entry_unittest.cc View 1 2 1 chunk +0 lines, -748 lines 0 comments Download
D content/browser/gpu/gpu_control_list_jsons.h View 1 2 1 chunk +0 lines, -19 lines 0 comments Download
D content/browser/gpu/gpu_control_list_machine_model_info_unittest.cc View 1 2 1 chunk +0 lines, -57 lines 0 comments Download
D content/browser/gpu/gpu_control_list_number_info_unittest.cc View 1 2 1 chunk +0 lines, -210 lines 0 comments Download
D content/browser/gpu/gpu_control_list_os_info_unittest.cc View 1 2 1 chunk +0 lines, -111 lines 0 comments Download
D content/browser/gpu/gpu_control_list_string_info_unittest.cc View 1 2 1 chunk +0 lines, -98 lines 0 comments Download
D content/browser/gpu/gpu_control_list_unittest.cc View 1 2 1 chunk +0 lines, -444 lines 0 comments Download
D content/browser/gpu/gpu_control_list_version_info_unittest.cc View 1 2 1 chunk +0 lines, -258 lines 0 comments Download
M content/browser/gpu/gpu_data_manager_impl.h View 1 2 4 chunks +6 lines, -6 lines 0 comments Download
M content/browser/gpu/gpu_data_manager_impl.cc View 1 2 4 chunks +4 lines, -4 lines 0 comments Download
M content/browser/gpu/gpu_data_manager_impl_private.h View 1 2 7 chunks +14 lines, -14 lines 0 comments Download
M content/browser/gpu/gpu_data_manager_impl_private.cc View 1 2 28 chunks +217 lines, -71 lines 0 comments Download
D content/browser/gpu/gpu_driver_bug_list.h View 1 2 1 chunk +0 lines, -29 lines 0 comments Download
D content/browser/gpu/gpu_driver_bug_list.cc View 1 2 1 chunk +0 lines, -48 lines 0 comments Download
D content/browser/gpu/gpu_driver_bug_list_json.cc View 1 2 1 chunk +0 lines, -353 lines 0 comments Download
D content/browser/gpu/gpu_driver_bug_list_unittest.cc View 1 2 1 chunk +0 lines, -81 lines 0 comments Download
M content/browser/gpu/gpu_internals_ui.cc View 1 2 21 chunks +32 lines, -30 lines 0 comments Download
M content/browser/gpu/gpu_process_host.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/gpu/gpu_process_host.cc View 1 2 4 chunks +5 lines, -5 lines 0 comments Download
M content/browser/gpu/gpu_process_host_ui_shim.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/gpu/gpu_process_host_ui_shim.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
D content/browser/gpu/gpu_switching_list.h View 1 2 1 chunk +0 lines, -29 lines 0 comments Download
D content/browser/gpu/gpu_switching_list.cc View 1 2 1 chunk +0 lines, -29 lines 0 comments Download
D content/browser/gpu/gpu_switching_list_json.cc View 1 2 1 chunk +0 lines, -125 lines 0 comments Download
D content/browser/gpu/gpu_switching_list_unittest.cc View 1 2 1 chunk +0 lines, -109 lines 0 comments Download
D content/browser/gpu/gpu_util.h View 1 2 1 chunk +0 lines, -39 lines 0 comments Download
D content/browser/gpu/gpu_util.cc View 1 2 1 chunk +0 lines, -191 lines 0 comments Download
D content/browser/gpu/gpu_util_unittest.cc View 1 2 1 chunk +0 lines, -78 lines 0 comments Download
D content/browser/gpu/software_rendering_list_json.cc View 1 2 1 chunk +0 lines, -1116 lines 0 comments Download
M content/browser/renderer_host/gpu_message_filter.h View 1 2 2 chunks +5 lines, -2 lines 0 comments Download
M content/browser/renderer_host/gpu_message_filter.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/common/gpu/client/gpu_channel_host.h View 1 2 3 chunks +4 lines, -4 lines 0 comments Download
M content/common/gpu/client/gpu_channel_host.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
D content/common/gpu/gpu_info_unittest.cc View 1 2 1 chunk +0 lines, -27 lines 0 comments Download
M content/common/gpu/gpu_messages.h View 1 2 4 chunks +7 lines, -7 lines 0 comments Download
M content/content_browser.gypi View 1 2 2 chunks +0 lines, -14 lines 0 comments Download
M content/content_common.gypi View 1 2 2 chunks +0 lines, -7 lines 0 comments Download
M content/content_gpu.gypi View 1 2 3 chunks +0 lines, -21 lines 0 comments Download
M content/content_tests.gypi View 1 2 3 chunks +0 lines, -14 lines 0 comments Download
M content/gpu/DEPS View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M content/gpu/gpu_child_thread.h View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M content/gpu/gpu_child_thread.cc View 1 2 3 chunks +5 lines, -5 lines 0 comments Download
D content/gpu/gpu_dx_diagnostics_win.cc View 1 2 1 chunk +0 lines, -139 lines 0 comments Download
D content/gpu/gpu_info_collector.h View 1 2 1 chunk +0 lines, -68 lines 0 comments Download
D content/gpu/gpu_info_collector.cc View 1 2 1 chunk +0 lines, -140 lines 0 comments Download
D content/gpu/gpu_info_collector_android.cc View 1 2 1 chunk +0 lines, -80 lines 0 comments Download
D content/gpu/gpu_info_collector_mac.mm View 1 2 1 chunk +0 lines, -220 lines 0 comments Download
D content/gpu/gpu_info_collector_unittest.cc View 1 2 1 chunk +0 lines, -181 lines 0 comments Download
D content/gpu/gpu_info_collector_win.cc View 1 2 1 chunk +0 lines, -643 lines 0 comments Download
D content/gpu/gpu_info_collector_x11.cc View 1 2 1 chunk +0 lines, -274 lines 0 comments Download
M content/gpu/gpu_main.cc View 1 2 6 chunks +7 lines, -8 lines 0 comments Download
M content/public/browser/gpu_data_manager.h View 1 2 2 chunks +6 lines, -3 lines 0 comments Download
M content/public/common/content_client.h View 1 2 3 chunks +5 lines, -2 lines 0 comments Download
D content/public/common/dx_diag_node.h View 1 2 1 chunk +0 lines, -25 lines 0 comments Download
D content/public/common/dx_diag_node.cc View 1 2 1 chunk +0 lines, -13 lines 0 comments Download
D content/public/common/gpu_feature_type.h View 1 2 1 chunk +0 lines, -32 lines 0 comments Download
D content/public/common/gpu_info.h View 1 2 1 chunk +0 lines, -130 lines 0 comments Download
D content/public/common/gpu_info.cc View 1 2 1 chunk +0 lines, -29 lines 0 comments Download
D content/public/common/gpu_performance_stats.h View 1 2 1 chunk +0 lines, -23 lines 0 comments Download
D content/public/common/gpu_switching_option.h View 1 2 1 chunk +0 lines, -23 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/renderer_webkitplatformsupport_impl.cc View 1 2 3 chunks +2 lines, -2 lines 0 comments Download
M content/test/gpu/gpu_test_config.h View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M content/test/gpu/gpu_test_config.cc View 1 2 3 chunks +9 lines, -9 lines 0 comments Download
M content/test/gpu/gpu_test_config_unittest.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M gpu/command_buffer/service/feature_info.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/feature_info_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
D gpu/command_buffer/service/gpu_driver_bug_workaround_type.h View 1 2 1 chunk +0 lines, -69 lines 0 comments Download
M gpu/command_buffer_service.gypi View 1 2 1 chunk +0 lines, -1 line 0 comments Download
A + gpu/config/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + gpu/config/dx_diag_node.h View 1 chunk +8 lines, -6 lines 0 comments Download
A + gpu/config/dx_diag_node.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + gpu/config/gpu_blacklist.h View 2 chunks +7 lines, -7 lines 0 comments Download
A + gpu/config/gpu_blacklist.cc View 2 chunks +4 lines, -4 lines 0 comments Download
A + gpu/config/gpu_blacklist_unittest.cc View 2 chunks +6 lines, -6 lines 0 comments Download
A + gpu/config/gpu_control_list.h View 10 chunks +14 lines, -14 lines 0 comments Download
A + gpu/config/gpu_control_list.cc View 3 chunks +5 lines, -5 lines 0 comments Download
A + gpu/config/gpu_control_list_entry_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
A + gpu/config/gpu_control_list_jsons.h View 1 chunk +9 lines, -9 lines 0 comments Download
A + gpu/config/gpu_control_list_machine_model_info_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A + gpu/config/gpu_control_list_number_info_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A + gpu/config/gpu_control_list_os_info_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A + gpu/config/gpu_control_list_string_info_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A + gpu/config/gpu_control_list_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
A + gpu/config/gpu_control_list_version_info_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A + gpu/config/gpu_driver_bug_list.h View 2 chunks +8 lines, -7 lines 0 comments Download
A + gpu/config/gpu_driver_bug_list.cc View 2 chunks +7 lines, -7 lines 0 comments Download
A + gpu/config/gpu_driver_bug_list_json.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A + gpu/config/gpu_driver_bug_list_unittest.cc View 3 chunks +8 lines, -8 lines 0 comments Download
A + gpu/config/gpu_driver_bug_workaround_type.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + gpu/config/gpu_dx_diagnostics_win.cc View 4 chunks +7 lines, -8 lines 0 comments Download
A + gpu/config/gpu_feature_type.h View 2 chunks +5 lines, -5 lines 0 comments Download
A + gpu/config/gpu_info.h View 3 chunks +10 lines, -10 lines 0 comments Download
A + gpu/config/gpu_info.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A + gpu/config/gpu_info_collector.h View 3 chunks +17 lines, -18 lines 0 comments Download
A + gpu/config/gpu_info_collector.cc View 4 chunks +6 lines, -6 lines 0 comments Download
A + gpu/config/gpu_info_collector_android.cc View 4 chunks +8 lines, -8 lines 0 comments Download
A + gpu/config/gpu_info_collector_mac.mm View 11 chunks +16 lines, -16 lines 0 comments Download
A + gpu/config/gpu_info_collector_unittest.cc View 5 chunks +26 lines, -21 lines 0 comments Download
A + gpu/config/gpu_info_collector_win.cc View 12 chunks +15 lines, -15 lines 0 comments Download
A + gpu/config/gpu_info_collector_x11.cc View 9 chunks +12 lines, -12 lines 0 comments Download
A + gpu/config/gpu_info_unittest.cc View 2 chunks +7 lines, -2 lines 0 comments Download
A + gpu/config/gpu_performance_stats.h View 2 chunks +7 lines, -7 lines 0 comments Download
A + gpu/config/gpu_switching_list.h View 2 chunks +7 lines, -7 lines 0 comments Download
A + gpu/config/gpu_switching_list.cc View 2 chunks +4 lines, -4 lines 0 comments Download
A + gpu/config/gpu_switching_list_json.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A + gpu/config/gpu_switching_list_unittest.cc View 2 chunks +6 lines, -6 lines 0 comments Download
A + gpu/config/gpu_switching_option.h View 2 chunks +6 lines, -7 lines 0 comments Download
A + gpu/config/gpu_util.h View 1 chunk +10 lines, -17 lines 0 comments Download
A + gpu/config/gpu_util.cc View 3 chunks +4 lines, -150 lines 0 comments Download
A + gpu/config/gpu_util_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A + gpu/config/software_rendering_list_json.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M gpu/gpu.gyp View 1 2 4 chunks +22 lines, -0 lines 0 comments Download
A gpu/gpu_config.gypi View 1 chunk +69 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Zhenyao Mo
Try to reland this CL. The patch set 1 is exactly the same as patch ...
7 years, 7 months ago (2013-05-22 19:39:03 UTC) #1
piman
lgtm
7 years, 7 months ago (2013-05-22 19:46:21 UTC) #2
Zhenyao Mo
sky: ash/ owner review please
7 years, 7 months ago (2013-05-22 19:48:42 UTC) #3
apatrick_chromium
https://codereview.chromium.org/15745014/diff/42001/content/browser/gamepad/gamepad_platform_data_fetcher_win.cc File content/browser/gamepad/gamepad_platform_data_fetcher_win.cc (right): https://codereview.chromium.org/15745014/diff/42001/content/browser/gamepad/gamepad_platform_data_fetcher_win.cc#newcode23 content/browser/gamepad/gamepad_platform_data_fetcher_win.cc:23: 18 #pragma comment(lib, "dxguid.lib") Delete "18"
7 years, 7 months ago (2013-05-22 19:52:03 UTC) #4
Ken Russell (switch to Gerrit)
LGTM with apatrick's issue addressed.
7 years, 7 months ago (2013-05-22 19:53:35 UTC) #5
Zhenyao Mo
Fixed. Al: please have another look. https://codereview.chromium.org/15745014/diff/42001/content/browser/gamepad/gamepad_platform_data_fetcher_win.cc File content/browser/gamepad/gamepad_platform_data_fetcher_win.cc (right): https://codereview.chromium.org/15745014/diff/42001/content/browser/gamepad/gamepad_platform_data_fetcher_win.cc#newcode23 content/browser/gamepad/gamepad_platform_data_fetcher_win.cc:23: 18 #pragma comment(lib, ...
7 years, 7 months ago (2013-05-22 20:01:39 UTC) #6
apatrick_chromium
lgtm
7 years, 7 months ago (2013-05-22 20:15:43 UTC) #7
sky
LGTM
7 years, 7 months ago (2013-05-22 21:14:26 UTC) #8
Jói
LGTM On Wed, May 22, 2013 at 2:14 PM, <sky@chromium.org> wrote: > LGTM > > ...
7 years, 7 months ago (2013-05-22 21:17:28 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zmo@chromium.org/15745014/47006
7 years, 7 months ago (2013-05-22 21:26:43 UTC) #10
commit-bot: I haz the power
Failed to apply patch for gpu/config/dx_diag_node.cc: While running patch -p0 --forward --force --no-backup-if-mismatch; can't find ...
7 years, 7 months ago (2013-05-22 21:27:30 UTC) #11
Zhenyao Mo
7 years, 7 months ago (2013-05-23 20:05:05 UTC) #12
Message was sent while issue was closed.
Committed patchset #3 manually as r201875.

Powered by Google App Engine
This is Rietveld 408576698