Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 1573293002: Change auto_bisect to post results to perf dashboard. (Closed)

Created:
4 years, 11 months ago by chrisphan
Modified:
4 years, 10 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Change auto_bisect to post results to perf dashboard. High level changes: bisect_results.py This is removed and replaced by bisector.get_result(), where we craft a object to be post to dashboard. local_bisect.py Change to call performance_dasboard.post_bisect for each revision and once on completion. perf_try Change to craft bisect result object and call performance_dasboard.post_bisect_results as well. This CL depends on CL: 1570513008 BUG=573308 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=298871

Patch Set 1 #

Patch Set 2 : Update #

Total comments: 1

Patch Set 3 : update #

Total comments: 10

Patch Set 4 : address comments #

Total comments: 2

Patch Set 5 : post_bisect to post_bisect_results #

Total comments: 3

Patch Set 6 : rebase #

Patch Set 7 : rebase #

Patch Set 8 : rebase #

Patch Set 9 : remove local changes #

Patch Set 10 : remove local change #

Patch Set 11 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1047 lines, -605 lines) Patch
M scripts/slave/recipe_modules/auto_bisect/__init__.py View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
D scripts/slave/recipe_modules/auto_bisect/bisect_results.py View 1 2 3 4 5 6 1 chunk +0 lines, -276 lines 0 comments Download
M scripts/slave/recipe_modules/auto_bisect/bisector.py View 1 2 3 4 5 6 6 chunks +103 lines, -15 lines 0 comments Download
M scripts/slave/recipe_modules/auto_bisect/local_bisect.py View 1 2 3 4 5 2 chunks +2 lines, -4 lines 0 comments Download
M scripts/slave/recipe_modules/perf_try/__init__.py View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipe_modules/perf_try/api.py View 1 2 3 4 5 5 chunks +106 lines, -36 lines 0 comments Download
M scripts/slave/recipes/bisect.py View 1 2 3 4 5 5 chunks +16 lines, -4 lines 0 comments Download
M scripts/slave/recipes/bisect.expected/basic.json View 1 2 3 4 5 6 4 chunks +48 lines, -39 lines 0 comments Download
M scripts/slave/recipes/bisect.expected/basic_return_code_test.json View 1 2 3 4 5 6 4 chunks +48 lines, -38 lines 0 comments Download
M scripts/slave/recipes/bisect.expected/broken_bad_revision_test.json View 1 2 3 4 5 6 2 chunks +13 lines, -13 lines 0 comments Download
M scripts/slave/recipes/bisect.expected/broken_good_revision_test.json View 1 2 3 4 5 6 2 chunks +13 lines, -13 lines 0 comments Download
M scripts/slave/recipes/bisect_test/example_bisect_results.py View 9 chunks +18 lines, -2 lines 0 comments Download
M scripts/slave/recipes/bisect_test/example_bisect_results.expected/aborted_non_telemetry_test.json View 1 2 3 4 5 1 chunk +9 lines, -10 lines 0 comments Download
M scripts/slave/recipes/bisect_test/example_bisect_results.expected/basic_test.json View 1 2 3 4 5 1 chunk +9 lines, -10 lines 0 comments Download
M scripts/slave/recipes/bisect_test/example_bisect_results.expected/deps_culprit_test.json View 1 2 3 4 5 1 chunk +9 lines, -10 lines 0 comments Download
M scripts/slave/recipes/bisect_test/example_bisect_results.expected/failed_direction_test.json View 1 2 3 4 5 1 chunk +9 lines, -10 lines 0 comments Download
M scripts/slave/recipes/bisect_test/example_bisect_results.expected/failed_test.json View 1 2 3 4 5 1 chunk +8 lines, -8 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_android_fyi_perf_bisect.json View 1 2 3 4 5 6 2 chunks +19 lines, -2 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_android_nexus5_perf_bisect.json View 1 2 3 4 5 6 2 chunks +19 lines, -2 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_android_nexus6_perf_bisect.json View 1 2 3 4 5 6 2 chunks +19 lines, -2 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_android_nexus7_perf_bisect.json View 1 2 3 4 5 6 2 chunks +19 lines, -2 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_android_nexus9_perf_bisect.json View 1 2 3 4 5 6 2 chunks +19 lines, -2 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_android_one_perf_bisect.json View 1 2 3 4 5 6 2 chunks +19 lines, -2 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_android_s5_perf_bisect.json View 1 2 3 4 5 6 2 chunks +19 lines, -2 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_android_s5_perf_cq.json View 1 2 3 4 5 6 2 chunks +19 lines, -2 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_android_webview_aosp_perf_bisect.json View 1 2 3 4 5 6 2 chunks +19 lines, -2 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_fyi_perf_bisect.json View 1 2 3 4 5 6 3 chunks +22 lines, -5 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_nexus5_perf_bisect.json View 1 2 3 4 5 6 3 chunks +22 lines, -5 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_nexus6_perf_bisect.json View 1 2 3 4 5 6 3 chunks +22 lines, -5 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_nexus7_perf_bisect.json View 1 2 3 4 5 6 3 chunks +22 lines, -5 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_nexus9_perf_bisect.json View 1 2 3 4 5 6 3 chunks +22 lines, -5 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_one_perf_bisect.json View 1 2 3 4 5 6 3 chunks +22 lines, -5 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_s5_perf_bisect.json View 1 2 3 4 5 6 3 chunks +22 lines, -5 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_s5_perf_cq.json View 1 2 3 4 5 6 3 chunks +22 lines, -5 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_webview_aosp_perf_bisect.json View 1 2 3 4 5 6 3 chunks +22 lines, -5 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_revisions_android_fyi_perf_bisect.json View 1 2 3 4 5 6 3 chunks +22 lines, -5 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_revisions_android_nexus5_perf_bisect.json View 1 2 3 4 5 6 3 chunks +22 lines, -5 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_revisions_android_nexus6_perf_bisect.json View 1 2 3 4 5 6 3 chunks +22 lines, -5 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_revisions_android_nexus7_perf_bisect.json View 1 2 3 4 5 6 3 chunks +22 lines, -5 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_revisions_android_nexus9_perf_bisect.json View 1 2 3 4 5 6 3 chunks +22 lines, -5 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_revisions_android_one_perf_bisect.json View 1 2 3 4 5 6 3 chunks +22 lines, -5 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_revisions_android_s5_perf_bisect.json View 1 2 3 4 5 6 3 chunks +22 lines, -5 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_revisions_android_s5_perf_cq.json View 1 2 3 4 5 6 3 chunks +22 lines, -5 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_revisions_android_webview_aosp_perf_bisect.json View 1 2 3 4 5 6 3 chunks +22 lines, -5 lines 0 comments Download
M scripts/slave/recipes/bisection/desktop_bisect.py View 1 2 3 4 5 3 chunks +10 lines, -3 lines 0 comments Download
M scripts/slave/recipes/bisection/desktop_bisect.expected/basic_perf_tryjob.json View 1 2 3 4 5 1 chunk +17 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/desktop_bisect.expected/basic_perf_tryjob_with_metric.json View 1 2 3 4 5 1 chunk +20 lines, -3 lines 0 comments Download
M scripts/slave/recipes/bisection/desktop_bisect.expected/basic_perf_tryjob_with_revisions.json View 1 2 3 4 5 1 chunk +20 lines, -3 lines 0 comments Download

Messages

Total messages: 46 (18 generated)
chrisphan
https://codereview.chromium.org/1573293002/diff/20001/scripts/slave/recipe_modules/auto_bisect/bisect_results.py File scripts/slave/recipe_modules/auto_bisect/bisect_results.py (left): https://codereview.chromium.org/1573293002/diff/20001/scripts/slave/recipe_modules/auto_bisect/bisect_results.py#oldcode10 scripts/slave/recipe_modules/auto_bisect/bisect_results.py:10: _RESULTS_BANNER = """ So most of this is moved ...
4 years, 11 months ago (2016-01-11 21:19:09 UTC) #7
chrisphan
4 years, 11 months ago (2016-01-11 22:42:14 UTC) #8
qyearsley
https://chromiumcodereview-hr.appspot.com/1573293002/diff/40001/scripts/slave/recipe_modules/auto_bisect/bisect_results_json.py File scripts/slave/recipe_modules/auto_bisect/bisect_results_json.py (right): https://chromiumcodereview-hr.appspot.com/1573293002/diff/40001/scripts/slave/recipe_modules/auto_bisect/bisect_results_json.py#newcode18 scripts/slave/recipe_modules/auto_bisect/bisect_results_json.py:18: def get(bisector): What do you think about making this ...
4 years, 11 months ago (2016-01-11 22:49:43 UTC) #10
RobertoCN
https://codereview.chromium.org/1573293002/diff/40001/scripts/slave/recipe_modules/auto_bisect/bisect_results_json.py File scripts/slave/recipe_modules/auto_bisect/bisect_results_json.py (right): https://codereview.chromium.org/1573293002/diff/40001/scripts/slave/recipe_modules/auto_bisect/bisect_results_json.py#newcode18 scripts/slave/recipe_modules/auto_bisect/bisect_results_json.py:18: def get(bisector): On 2016/01/11 22:49:43, qyearsley wrote: > What ...
4 years, 11 months ago (2016-01-12 20:47:29 UTC) #11
chrisphan
https://codereview.chromium.org/1573293002/diff/40001/scripts/slave/recipe_modules/auto_bisect/bisect_results_json.py File scripts/slave/recipe_modules/auto_bisect/bisect_results_json.py (right): https://codereview.chromium.org/1573293002/diff/40001/scripts/slave/recipe_modules/auto_bisect/bisect_results_json.py#newcode18 scripts/slave/recipe_modules/auto_bisect/bisect_results_json.py:18: def get(bisector): On 2016/01/12 20:47:29, RobertoCN wrote: > On ...
4 years, 11 months ago (2016-01-14 00:53:26 UTC) #12
chrisphan
Bump
4 years, 11 months ago (2016-01-14 23:55:45 UTC) #13
qyearsley
On 2016/01/14 23:55:45, chrisphan wrote: > Bump LGTM as far as I can see; Roberto ...
4 years, 11 months ago (2016-01-17 22:48:51 UTC) #14
qyearsley
https://codereview.chromium.org/1573293002/diff/60001/scripts/slave/recipe_modules/auto_bisect/bisect_results.py File scripts/slave/recipe_modules/auto_bisect/bisect_results.py (left): https://codereview.chromium.org/1573293002/diff/60001/scripts/slave/recipe_modules/auto_bisect/bisect_results.py#oldcode1 scripts/slave/recipe_modules/auto_bisect/bisect_results.py:1: # Copyright 2015 The Chromium Authors. All rights reserved. ...
4 years, 11 months ago (2016-01-17 22:49:19 UTC) #15
RobertoCN
This looks good, I would only ask that you add a flag or something to ...
4 years, 11 months ago (2016-01-21 18:55:09 UTC) #17
chrisphan
On 2016/01/21 18:55:09, RobertoCN wrote: > This looks good, I would only ask that you ...
4 years, 11 months ago (2016-01-21 21:31:22 UTC) #18
prasadv
https://codereview.chromium.org/1573293002/diff/80001/scripts/slave/recipe_modules/perf_try/api.py File scripts/slave/recipe_modules/perf_try/api.py (right): https://codereview.chromium.org/1573293002/diff/80001/scripts/slave/recipe_modules/perf_try/api.py#newcode101 scripts/slave/recipe_modules/perf_try/api.py:101: self.m.perf_dashboard.post_bisect_results( Why do you want to post results of ...
4 years, 11 months ago (2016-01-22 18:15:02 UTC) #19
chrisphan
https://codereview.chromium.org/1573293002/diff/80001/scripts/slave/recipe_modules/perf_try/api.py File scripts/slave/recipe_modules/perf_try/api.py (right): https://codereview.chromium.org/1573293002/diff/80001/scripts/slave/recipe_modules/perf_try/api.py#newcode101 scripts/slave/recipe_modules/perf_try/api.py:101: self.m.perf_dashboard.post_bisect_results( On 2016/01/22 18:15:02, prasadv wrote: > Why do ...
4 years, 11 months ago (2016-01-22 18:30:02 UTC) #20
chrisphan
On 2016/01/22 18:30:02, chrisphan wrote: > https://codereview.chromium.org/1573293002/diff/80001/scripts/slave/recipe_modules/perf_try/api.py > File scripts/slave/recipe_modules/perf_try/api.py (right): > > https://codereview.chromium.org/1573293002/diff/80001/scripts/slave/recipe_modules/perf_try/api.py#newcode101 > ...
4 years, 11 months ago (2016-01-22 18:39:27 UTC) #21
chrisphan
So per offline talk, the switch not post results won't apply here since this change ...
4 years, 11 months ago (2016-01-22 19:44:28 UTC) #22
qyearsley
LGTM, although this CL should be LGTMd by Roberto or Prasad, and it still depends ...
4 years, 11 months ago (2016-01-26 22:10:50 UTC) #23
chrisphan
Ran this change on linux and windows local setup. Anything else here Roberto and Prasadv? ...
4 years, 10 months ago (2016-02-05 18:53:16 UTC) #24
RobertoCN
On 2016/02/05 at 18:53:16, chrisphan wrote: > Ran this change on linux and windows local ...
4 years, 10 months ago (2016-02-09 21:40:07 UTC) #25
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1573293002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1573293002/120001
4 years, 10 months ago (2016-02-18 23:18:24 UTC) #27
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-18 23:22:05 UTC) #29
chrisphan
On 2016/02/09 21:40:07, RobertoCN wrote: > On 2016/02/05 at 18:53:16, chrisphan wrote: > > Ran ...
4 years, 10 months ago (2016-02-18 23:23:40 UTC) #30
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1573293002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1573293002/120001
4 years, 10 months ago (2016-02-18 23:23:55 UTC) #33
commit-bot: I haz the power
Try jobs failed on following builders: Build Presubmit on tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Build%20Presubmit/builds/2276)
4 years, 10 months ago (2016-02-18 23:37:20 UTC) #35
prasadv
lgtm
4 years, 10 months ago (2016-02-19 00:05:44 UTC) #36
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1573293002/200001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1573293002/200001
4 years, 10 months ago (2016-02-19 00:06:59 UTC) #39
commit-bot: I haz the power
Try jobs failed on following builders: Build Presubmit on tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Build%20Presubmit/builds/2280)
4 years, 10 months ago (2016-02-19 00:19:50 UTC) #41
RobertoCN
rs-lgtm
4 years, 10 months ago (2016-02-19 01:34:57 UTC) #42
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1573293002/200001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1573293002/200001
4 years, 10 months ago (2016-02-19 01:38:44 UTC) #44
commit-bot: I haz the power
4 years, 10 months ago (2016-02-19 01:45:45 UTC) #46
Message was sent while issue was closed.
Committed patchset #11 (id:200001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=298871

Powered by Google App Engine
This is Rietveld 408576698