Enable AndroidWebViewTest and ChromeSyncShellTest instrumentation tests for GN

Enable AndroidWebViewTest and ChromeSyncShellTest instrumentation tests for GN

BUG=510485
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=298186

[agrieve, 2015-12-30 21:19:25]

agrieve@chromium.org changed reviewers:
+ dpranke@chromium.org

[agrieve, 2015-12-30 21:19:26]

My attempt to test these on the trybot looks to have tried to apply this patch
to src/ rather than build/. Any way to try before committing?

[agrieve, 2016-01-08 01:51:23]

agrieve@chromium.org changed reviewers:
+ jbudorick@chromium.org

[agrieve, 2016-01-08 01:51:24]

Dirk's out for a few more days, but I'd like to ensure these pass on the bots.
John-can you review?

[jbudorick, 2016-01-08 01:55:33]

jbudorick@chromium.org changed reviewers:
+ sergeyberezin@chromium.org

[jbudorick, 2016-01-08 01:55:34]

lgtm w/ nit, but I'm not an OWNER for chromium_tests, so +sergeyberezin

also, there's no way to try a recipe change on the bot AFAIK

https://codereview.chromium.org/1556693002/diff/1/scripts/slave/recipe_module...
File scripts/slave/recipe_modules/chromium_tests/chromium_linux.py (right):

https://codereview.chromium.org/1556693002/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/chromium_tests/chromium_linux.py:154:
steps.AndroidInstrumentationTest('ChromeSyncShellTest'),
nit: move above ContentShellTest

[Sergey Berezin, 2016-01-08 19:46:17]

rs lgtm

[agrieve, 2016-01-08 20:01:27]

https://codereview.chromium.org/1556693002/diff/1/scripts/slave/recipe_module...
File scripts/slave/recipe_modules/chromium_tests/chromium_linux.py (right):

https://codereview.chromium.org/1556693002/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/chromium_tests/chromium_linux.py:154:
steps.AndroidInstrumentationTest('ChromeSyncShellTest'),
On 2016/01/08 01:55:34, jbudorick wrote:
> nit: move above ContentShellTest

Done.

[agrieve, 2016-01-08 20:02:48]

The CQ bit was checked by agrieve@chromium.org

[agrieve, 2016-01-08 20:02:48]

The patchset sent to the CQ was uploaded after l-g-t-m from
sergeyberezin@chromium.org, jbudorick@chromium.org
Link to the patchset: https://codereview.chromium.org/1556693002/#ps20001
(title: "change order")

[commit-bot: I haz the power, 2016-01-08 20:02:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-08 20:02:54]

This CL has an open dependency (Issue 1556693002 Patch 1). Please resolve the
dependency and try again.

[agrieve, 2016-01-09 18:44:24]

The CQ bit was checked by agrieve@chromium.org

[agrieve, 2016-01-09 18:44:24]

The patchset sent to the CQ was uploaded after l-g-t-m from
sergeyberezin@chromium.org, jbudorick@chromium.org
Link to the patchset: https://codereview.chromium.org/1556693002/#ps60001
(title: "try to fix depending on self")

[commit-bot: I haz the power, 2016-01-09 18:44:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-09 18:44:32]

This CL has an open dependency (Issue 1556693002 Patch 1). Please resolve the
dependency and try again.

[agrieve, 2016-01-09 18:47:13]

The CQ bit was checked by agrieve@chromium.org

[agrieve, 2016-01-09 18:47:13]

The patchset sent to the CQ was uploaded after l-g-t-m from
sergeyberezin@chromium.org, jbudorick@chromium.org
Link to the patchset: https://codereview.chromium.org/1556693002/#ps80001
(title: " ")

[commit-bot: I haz the power, 2016-01-09 18:47:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1556693002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1556693002/80001

[commit-bot: I haz the power, 2016-01-09 18:49:59]

Description was changed from

==========
Enable AndroidWebViewTest and ChromeSyncShellTest instrumentation tests for GN

BUG=510485
==========

to

==========
Enable AndroidWebViewTest and ChromeSyncShellTest instrumentation tests for GN

BUG=510485

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=298186
==========

[commit-bot: I haz the power, 2016-01-09 18:50:00]

Committed patchset #5 (id:80001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=298186

[Dirk Pranke, 2016-01-26 02:10:44]

lgtm