Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1175)

Issue 1578703002: V8 Buildbot: Switch static-initializer check to swarming. (Closed)

Created:
4 years, 11 months ago by Michael Achenbach
Modified:
4 years, 11 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

V8 Buildbot: Switch static-initializer check to swarming. BUG=535160 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=298187

Patch Set 1 #

Total comments: 3

Messages

Total messages: 8 (4 generated)
Michael Achenbach
PTAL https://codereview.chromium.org/1578703002/diff/1/scripts/slave/recipe_modules/v8/api.py File scripts/slave/recipe_modules/v8/api.py (right): https://codereview.chromium.org/1578703002/diff/1/scripts/slave/recipe_modules/v8/api.py#newcode280 scripts/slave/recipe_modules/v8/api.py:280: if not test.swarming: # pragma: no cover I'll ...
4 years, 11 months ago (2016-01-11 08:37:42 UTC) #3
tandrii(chromium)
lgtm https://codereview.chromium.org/1578703002/diff/1/scripts/slave/recipe_modules/v8/testing.py File scripts/slave/recipe_modules/v8/testing.py (left): https://codereview.chromium.org/1578703002/diff/1/scripts/slave/recipe_modules/v8/testing.py#oldcode354 scripts/slave/recipe_modules/v8/testing.py:354: class V8CheckInitializers(BaseTest): On 2016/01/11 08:37:42, Michael Achenbach wrote: ...
4 years, 11 months ago (2016-01-11 08:39:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1578703002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1578703002/1
4 years, 11 months ago (2016-01-11 09:18:32 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-11 09:21:24 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=298187

Powered by Google App Engine
This is Rietveld 408576698