V8 Buildbot: Remove swarming staging builders/testers.

V8 Buildbot: Remove swarming staging builders/testers.

This also includes a refactoring of the subdir slaves
distribution code.

BUG=535160
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=298192

[Michael Achenbach, 2016-01-11 10:03:16]

Description was changed from

==========
V8 Buildbot: Remove swarming stating builders/testers.

BUG=
==========

to

==========
V8 Buildbot: Remove swarming staging builders/testers.

BUG=
==========

[Michael Achenbach, 2016-01-11 10:41:23]

The CQ bit was checked by machenbach@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-11 10:41:32]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1573093002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1573093002/20001

[Michael Achenbach, 2016-01-11 10:42:08]

Description was changed from

==========
V8 Buildbot: Remove swarming staging builders/testers.

BUG=
==========

to

==========
V8 Buildbot: Remove swarming staging builders/testers.

This also includes a refactoring of the subdir slaves
distribution code.

BUG=535160
==========

[Michael Achenbach, 2016-01-11 10:42:08]

machenbach@chromium.org changed reviewers:
+ kjellander@chromium.org, tandrii@chromium.org

[Michael Achenbach, 2016-01-11 10:42:16]

PTAL

[kjellander_chromium, 2016-01-11 10:51:23]

https://codereview.chromium.org/1573093002/diff/20001/masters/master.client.v...
File masters/master.client.v8/slaves.cfg (right):

https://codereview.chromium.org/1573093002/diff/20001/masters/master.client.v...
masters/master.client.v8/slaves.cfg:404: Example: Distributing buidlers [A, B,
C, D, E] to slaves [X, Y] will result
buidlers -> builders

https://codereview.chromium.org/1573093002/diff/20001/masters/master.client.v...
masters/master.client.v8/slaves.cfg:410: # Assuming there are more or equal
builders than hostnames.
put that into an assert instead?

[commit-bot: I haz the power, 2016-01-11 10:53:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-11 10:53:41]

Dry run: Try jobs failed on following builders:
  Build Presubmit on tryserver.infra (JOB_FAILED,
https://build.chromium.org/p/tryserver.infra/builders/Build%20Presubmit/build...)

[Michael Achenbach, 2016-01-11 10:55:00]

The CQ bit was checked by machenbach@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-11 10:55:10]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1573093002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1573093002/40001

[Michael Achenbach, 2016-01-11 10:57:27]

Remark: This kind of distribution has the (small) drawback that when adding one
more slave, I also have to restart all the others assigned so far, because their
subdir indexes change. This might only be a problem if I ever end up with more
than 5 slaves (unlikely).

https://codereview.chromium.org/1573093002/diff/20001/masters/master.client.v...
File masters/master.client.v8/slaves.cfg (right):

https://codereview.chromium.org/1573093002/diff/20001/masters/master.client.v...
masters/master.client.v8/slaves.cfg:404: Example: Distributing buidlers [A, B,
C, D, E] to slaves [X, Y] will result
On 2016/01/11 10:51:23, kjellander (chromium) wrote:
> buidlers -> builders

Done.

https://codereview.chromium.org/1573093002/diff/20001/masters/master.client.v...
masters/master.client.v8/slaves.cfg:410: # Assuming there are more or equal
builders than hostnames.
On 2016/01/11 10:51:23, kjellander (chromium) wrote:
> put that into an assert instead?

Done.

[commit-bot: I haz the power, 2016-01-11 10:58:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-11 10:58:11]

Dry run: This issue passed the CQ dry run.

[tandrii(chromium), 2016-01-11 11:15:22]

lgtm % suggeston

https://codereview.chromium.org/1573093002/diff/40001/masters/master.client.v...
File masters/master.client.v8/slaves.cfg (right):

https://codereview.chromium.org/1573093002/diff/40001/masters/master.client.v...
masters/master.client.v8/slaves.cfg:408: # Assuming there are more or equal
builders than hostnames.
I'd also sort builders and hostnames to make sure this is totally deterministic
and not dependent on inputs.

If say, someone calls this func with dict argument, it'd still work, but won't
be deterministic any more.

[Michael Achenbach, 2016-01-11 11:23:45]

https://codereview.chromium.org/1573093002/diff/40001/masters/master.client.v...
File masters/master.client.v8/slaves.cfg (right):

https://codereview.chromium.org/1573093002/diff/40001/masters/master.client.v...
masters/master.client.v8/slaves.cfg:408: # Assuming there are more or equal
builders than hostnames.
On 2016/01/11 11:15:22, tandrii(chromium) wrote:
> I'd also sort builders and hostnames to make sure this is totally
deterministic
> and not dependent on inputs.
> 
> If say, someone calls this func with dict argument, it'd still work, but won't
> be deterministic any more.

Ensuring lists are used by another assert. I don't want to sort, as sorting
might change the distribution when adding new builders.

[Michael Achenbach, 2016-01-11 11:23:55]

The CQ bit was checked by machenbach@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-11 11:24:05]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1573093002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1573093002/60001

[commit-bot: I haz the power, 2016-01-11 11:29:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-11 11:29:55]

Dry run: This issue passed the CQ dry run.

[kjellander_chromium, 2016-01-11 11:41:23]

lgtm

[Michael Achenbach, 2016-01-11 13:39:13]

The CQ bit was checked by machenbach@chromium.org

[Michael Achenbach, 2016-01-11 13:39:14]

The patchset sent to the CQ was uploaded after l-g-t-m from tandrii@chromium.org
Link to the patchset: https://codereview.chromium.org/1573093002/#ps60001
(title: "Review")

[commit-bot: I haz the power, 2016-01-11 13:39:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1573093002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1573093002/60001

[commit-bot: I haz the power, 2016-01-11 13:45:21]

Description was changed from

==========
V8 Buildbot: Remove swarming staging builders/testers.

This also includes a refactoring of the subdir slaves
distribution code.

BUG=535160
==========

to

==========
V8 Buildbot: Remove swarming staging builders/testers.

This also includes a refactoring of the subdir slaves
distribution code.

BUG=535160

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=298192
==========

[commit-bot: I haz the power, 2016-01-11 13:45:21]

Committed patchset #4 (id:60001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=298192