Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 1575833003: Add recipe for testing recipe simulation. (Closed)

Created:
4 years, 11 months ago by tandrii(chromium)
Modified:
4 years, 11 months ago
Reviewers:
Michael Achenbach
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Add recipe for testing recipe simulation. Also add it to master.chromium.tools.build on {win,linux,mac} platforms. R=machenbach@chromium.org BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=298196

Patch Set 1 #

Total comments: 5

Patch Set 2 : review #

Total comments: 1

Patch Set 3 : argh #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -11 lines) Patch
M masters/master.chromium.tools.build/builders.pyl View 1 chunk +21 lines, -0 lines 0 comments Download
A scripts/slave/recipes/infra/recipe_simulation.py View 1 2 1 chunk +31 lines, -0 lines 0 comments Download
A + scripts/slave/recipes/infra/recipe_simulation.expected/normal.json View 1 3 chunks +14 lines, -11 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
tandrii(chromium)
PTAL
4 years, 11 months ago (2016-01-11 14:45:36 UTC) #1
tandrii(chromium)
https://codereview.chromium.org/1575833003/diff/1/scripts/slave/recipes/infra/recipe_simulation.py File scripts/slave/recipes/infra/recipe_simulation.py (right): https://codereview.chromium.org/1575833003/diff/1/scripts/slave/recipes/infra/recipe_simulation.py#newcode19 scripts/slave/recipes/infra/recipe_simulation.py:19: api.step('recipe fetch deps', [recipes_py, 'fetch']) technically, step below fetches ...
4 years, 11 months ago (2016-01-11 14:46:42 UTC) #2
Michael Achenbach
lgtm https://codereview.chromium.org/1575833003/diff/1/scripts/slave/recipes/infra/recipe_simulation.py File scripts/slave/recipes/infra/recipe_simulation.py (right): https://codereview.chromium.org/1575833003/diff/1/scripts/slave/recipes/infra/recipe_simulation.py#newcode29 scripts/slave/recipes/infra/recipe_simulation.py:29: revision_tag='deadbeaf', Should this not just be revision?
4 years, 11 months ago (2016-01-11 14:54:59 UTC) #3
Michael Achenbach
https://codereview.chromium.org/1575833003/diff/1/scripts/slave/recipes/infra/recipe_simulation.py File scripts/slave/recipes/infra/recipe_simulation.py (right): https://codereview.chromium.org/1575833003/diff/1/scripts/slave/recipes/infra/recipe_simulation.py#newcode16 scripts/slave/recipes/infra/recipe_simulation.py:16: api.gclient.set_config('build') Suggestion: You could also force bot_update to use ...
4 years, 11 months ago (2016-01-11 14:56:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1575833003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1575833003/20001
4 years, 11 months ago (2016-01-11 15:21:10 UTC) #7
tandrii(chromium)
https://codereview.chromium.org/1575833003/diff/1/scripts/slave/recipes/infra/recipe_simulation.py File scripts/slave/recipes/infra/recipe_simulation.py (right): https://codereview.chromium.org/1575833003/diff/1/scripts/slave/recipes/infra/recipe_simulation.py#newcode16 scripts/slave/recipes/infra/recipe_simulation.py:16: api.gclient.set_config('build') On 2016/01/11 14:56:25, Michael Achenbach wrote: > Suggestion: ...
4 years, 11 months ago (2016-01-11 15:21:35 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: Build Presubmit on tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Build%20Presubmit/builds/1003)
4 years, 11 months ago (2016-01-11 15:33:25 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1575833003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1575833003/40001
4 years, 11 months ago (2016-01-11 15:34:34 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001) as http://src.chromium.org/viewvc/chrome?view=rev&revision=298196
4 years, 11 months ago (2016-01-11 15:37:32 UTC) #15
Michael Achenbach
4 years, 11 months ago (2016-01-11 16:05:11 UTC) #16
Message was sent while issue was closed.
https://codereview.chromium.org/1575833003/diff/20001/scripts/slave/recipes/i...
File scripts/slave/recipes/infra/recipe_simulation.expected/normal.json (right):

https://codereview.chromium.org/1575833003/diff/20001/scripts/slave/recipes/i...
scripts/slave/recipes/infra/recipe_simulation.expected/normal.json:22:
"build@deadbeaf",
Looks like the bot_update api already uses the revision property by default if
present to sync to the desired revision.

Powered by Google App Engine
This is Rietveld 408576698