Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1571033002: remove imagefilter::sizeconstraint (Closed)

Created:
4 years, 11 months ago by reed1
Modified:
4 years, 11 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -105 lines) Patch
M include/core/SkImageFilter.h View 1 2 2 chunks +2 lines, -11 lines 0 comments Download
M include/gpu/GrTextureProvider.h View 1 1 chunk +0 lines, -25 lines 0 comments Download
M src/core/SkCanvas.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M src/core/SkDevice.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M src/core/SkImageFilter.cpp View 1 2 5 chunks +6 lines, -19 lines 0 comments Download
M src/core/SkLocalMatrixImageFilter.cpp View 1 2 1 chunk +2 lines, -3 lines 0 comments Download
M src/effects/SkBlurImageFilter.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M src/effects/SkBlurMaskFilter.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M src/effects/SkComposeImageFilter.cpp View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M src/effects/SkDisplacementMapEffect.cpp View 1 1 chunk +1 line, -2 lines 0 comments Download
M src/effects/SkGpuBlurUtils.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/effects/SkGpuBlurUtils.cpp View 1 2 chunks +3 lines, -4 lines 0 comments Download
M src/effects/SkLightingImageFilter.cpp View 1 1 chunk +1 line, -2 lines 0 comments Download
M src/effects/SkMorphologyImageFilter.cpp View 1 4 chunks +4 lines, -13 lines 0 comments Download
M src/effects/SkXfermodeImageFilter.cpp View 1 1 chunk +1 line, -2 lines 0 comments Download
M src/gpu/GrLayerHoister.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/SkGpuDevice.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/ImageFilterTest.cpp View 6 chunks +7 lines, -8 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1571033002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1571033002/40001
4 years, 11 months ago (2016-01-09 19:46:48 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-09 20:03:20 UTC) #5
reed1
ptal is it ok to remove this infrastructure? we don't use it anymore, but this ...
4 years, 11 months ago (2016-01-10 02:18:24 UTC) #7
bsalomon
lgtm
4 years, 11 months ago (2016-01-11 16:11:38 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1571033002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1571033002/40001
4 years, 11 months ago (2016-01-11 18:41:50 UTC) #10
commit-bot: I haz the power
4 years, 11 months ago (2016-01-11 18:57:02 UTC) #12
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/4e23cdaa6b892afeaa150c6d74099dc6c2065b7e

Powered by Google App Engine
This is Rietveld 408576698