Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 1569403002: Fix radii calculation (Closed)

Created:
4 years, 11 months ago by herb_g
Modified:
4 years, 11 months ago
Reviewers:
robertphillips, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Add fuzz test cases. #

Total comments: 1

Patch Set 3 : update comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+158 lines, -41 lines) Patch
M src/core/SkRRect.cpp View 3 chunks +13 lines, -41 lines 0 comments Download
A src/core/SkScaleToSides.h View 1 2 1 chunk +61 lines, -0 lines 0 comments Download
M tests/DrawPathTest.cpp View 1 2 chunks +35 lines, -0 lines 0 comments Download
A tests/ScaleToSidesTest.cpp View 1 chunk +49 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (10 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1569403002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1569403002/1
4 years, 11 months ago (2016-01-08 20:18:16 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_64-Debug-Trybot/builds/5254)
4 years, 11 months ago (2016-01-08 20:20:16 UTC) #6
herb_g
Add fuzz test cases.
4 years, 11 months ago (2016-01-08 20:51:05 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1569403002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1569403002/20001
4 years, 11 months ago (2016-01-08 20:54:39 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-08 21:14:17 UTC) #11
robertphillips
lgtm https://codereview.chromium.org/1569403002/diff/20001/src/core/SkScaleToSides.h File src/core/SkScaleToSides.h (right): https://codereview.chromium.org/1569403002/diff/20001/src/core/SkScaleToSides.h#newcode46 src/core/SkScaleToSides.h:46: comment out of date ?
4 years, 11 months ago (2016-01-08 22:15:33 UTC) #13
herb_g
update comment.
4 years, 11 months ago (2016-01-11 15:43:00 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1569403002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1569403002/40001
4 years, 11 months ago (2016-01-11 15:44:18 UTC) #17
commit-bot: I haz the power
4 years, 11 months ago (2016-01-11 16:08:59 UTC) #19
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/7cf12ddb8c1c2cf7a0eec63439148cc6b2bc104a

Powered by Google App Engine
This is Rietveld 408576698