Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1629)

Unified Diff: tests/DrawPathTest.cpp

Issue 1569403002: Fix radii calculation (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: update comment. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/core/SkScaleToSides.h ('k') | tests/ScaleToSidesTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/DrawPathTest.cpp
diff --git a/tests/DrawPathTest.cpp b/tests/DrawPathTest.cpp
index 364a2971230c52e9e1533a79861526e774e3758d..e9aa4499d995c46b6202154b7d09d6bf8344b112 100644
--- a/tests/DrawPathTest.cpp
+++ b/tests/DrawPathTest.cpp
@@ -313,6 +313,39 @@ static void test_crbug_165432(skiatest::Reporter* reporter) {
REPORTER_ASSERT(reporter, filteredPath.isEmpty());
}
+// http://crbug.com/472147
+// This is a simplified version from the bug. RRect radii not properly scaled.
+static void test_crbug_472147_simple(skiatest::Reporter* reporter) {
+ SkAutoTUnref<SkSurface> surface(SkSurface::NewRasterN32Premul(1000, 1000));
+ SkCanvas* canvas = surface->getCanvas();
+ SkPaint p;
+ SkRect r = SkRect::MakeLTRB(-246.0f, 33.0f, 848.0f, 33554464.0f);
+ SkVector radii[4] = {
+ { 13.0f, 8.0f }, { 170.0f, 2.0 }, { 256.0f, 33554430.0f }, { 120.0f, 5.0f }
+ };
+ SkRRect rr;
+ rr.setRectRadii(r, radii);
+ canvas->drawRRect(rr, p);
+}
+
+// http://crbug.com/472147
+// RRect radii not properly scaled.
+static void test_crbug_472147_actual(skiatest::Reporter* reporter) {
+ SkAutoTUnref<SkSurface> surface(SkSurface::NewRasterN32Premul(1000, 1000));
+ SkCanvas* canvas = surface->getCanvas();
+ SkPaint p;
+ SkRect r = SkRect::MakeLTRB(-246.0f, 33.0f, 848.0f, 33554464.0f);
+ SkVector radii[4] = {
+ { 13.0f, 8.0f }, { 170.0f, 2.0 }, { 256.0f, 33554430.0f }, { 120.0f, 5.0f }
+ };
+ SkRRect rr;
+ rr.setRectRadii(r, radii);
+ canvas->clipRRect(rr, SkRegion::kIntersect_Op, false);
+
+ SkRect r2 = SkRect::MakeLTRB(0, 33, 1102, 33554464);
+ canvas->drawRect(r2, p);
+}
+
DEF_TEST(DrawPath, reporter) {
test_giantaa();
test_bug533();
@@ -325,6 +358,8 @@ DEF_TEST(DrawPath, reporter) {
if (false) test_crbug131181();
test_infinite_dash(reporter);
test_crbug_165432(reporter);
+ test_crbug_472147_simple(reporter);
+ test_crbug_472147_actual(reporter);
test_big_aa_rect(reporter);
test_halfway();
}
« no previous file with comments | « src/core/SkScaleToSides.h ('k') | tests/ScaleToSidesTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698