Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 1555893002: Linux/CrOS/Cast/Android (and Mac with gn): Build 3rd-party code with -Wall. (Closed)

Created:
4 years, 11 months ago by Nico
Modified:
4 years, 11 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Linux/CrOS/Cast/Android (and Mac with gn): Build 3rd-party code with -Wall. Lands the remaining -Wall bits of https://codereview.chromium.org/1551753002/ (reviewed there). Windows, Mac, and iOS already build 3rd-party code with -Wall. (Mac and iOS only in the gyp build, not in gn yet.) This makes the other platforms match and also adds -Wall to no_chromium_code in gn builds. BUG=573250 TBR=thestig@chromium.org Committed: https://crrev.com/550440b4763042d462c7b0fc09dfba1408be8a8c Cr-Commit-Position: refs/heads/master@{#367275}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -6 lines) Patch
M build/common.gypi View 2 chunks +7 lines, -6 lines 0 comments Download
M build/config/compiler/BUILD.gn View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
Nico
4 years, 11 months ago (2016-01-02 00:12:49 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1555893002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1555893002/1
4 years, 11 months ago (2016-01-02 00:13:52 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-02 03:11:12 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/550440b4763042d462c7b0fc09dfba1408be8a8c Cr-Commit-Position: refs/heads/master@{#367275}
4 years, 11 months ago (2016-01-02 03:12:25 UTC) #6
Lei Zhang
lgtm
4 years, 11 months ago (2016-01-04 19:12:40 UTC) #7
ImFknAwesome1
lgtm
4 years, 11 months ago (2016-01-07 01:37:26 UTC) #9
ImFknAwesome1
lgtm
4 years, 11 months ago (2016-01-07 01:37:28 UTC) #10
ImFknAwesome1
lgtm
4 years, 11 months ago (2016-01-07 01:37:30 UTC) #11
ImFknAwesome1
4 years, 11 months ago (2016-01-07 01:43:42 UTC) #12
Message was sent while issue was closed.
On 2016/01/07 01:37:30, ImFknAwesome1 wrote:
> lgtm

Glyn

Powered by Google App Engine
This is Rietveld 408576698