Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(696)

Unified Diff: build/common.gypi

Issue 1555893002: Linux/CrOS/Cast/Android (and Mac with gn): Build 3rd-party code with -Wall. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/config/compiler/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index ae65c06a52e36a39c7934d224faeefe4c8df3da3..cbea95780ec9259301466486890457d51b26eb90 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -3140,12 +3140,8 @@
},
'conditions': [
[ 'os_posix==1 and OS!="mac" and OS!="ios"', {
- # We don't want to get warnings from third-party code,
- # so remove any existing warning-enabling flags like -Wall.
- 'cflags!': [
- '-Wall',
- '-Wextra',
- ],
+ # Remove -Wextra for third-party code.
+ 'cflags!': [ '-Wextra' ],
'cflags_cc': [
# Don't warn about hash_map in third-party code.
'-Wno-deprecated',
@@ -3156,6 +3152,11 @@
'-Wno-format',
],
}],
+ [ 'os_posix==1 and clang!=1 and OS!="mac" and OS!="ios"', {
+ # When we don't control the compiler, don't use -Wall for
+ # third-party code either.
+ 'cflags!': [ '-Wall' ],
+ }],
# TODO: Fix all warnings on chromeos too.
[ 'os_posix==1 and OS!="mac" and OS!="ios" and (clang!=1 or chromeos==1)', {
'cflags!': [
« no previous file with comments | « no previous file | build/config/compiler/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698