Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Side by Side Diff: build/config/compiler/BUILD.gn

Issue 1555893002: Linux/CrOS/Cast/Android (and Mac with gn): Build 3rd-party code with -Wall. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « build/common.gypi ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/android/config.gni") 5 import("//build/config/android/config.gni")
6 import("//build/config/chrome_build.gni") 6 import("//build/config/chrome_build.gni")
7 import("//build/config/compiler/compiler.gni") 7 import("//build/config/compiler/compiler.gni")
8 import("//build/config/nacl/config.gni") 8 import("//build/config/nacl/config.gni")
9 import("//build/toolchain/ccache.gni") 9 import("//build/toolchain/ccache.gni")
10 10
(...skipping 922 matching lines...) Expand 10 before | Expand all | Expand 10 after
933 cflags += [ 933 cflags += [
934 "/W3", # Warning level 3. 934 "/W3", # Warning level 3.
935 "/wd4800", # Disable warning when forcing value to bool. 935 "/wd4800", # Disable warning when forcing value to bool.
936 "/wd4267", # TODO(jschuh): size_t to int. 936 "/wd4267", # TODO(jschuh): size_t to int.
937 "/wd4996", # Deprecated function warning. 937 "/wd4996", # Deprecated function warning.
938 ] 938 ]
939 defines += [ 939 defines += [
940 "_CRT_NONSTDC_NO_WARNINGS", 940 "_CRT_NONSTDC_NO_WARNINGS",
941 "_CRT_NONSTDC_NO_DEPRECATE", 941 "_CRT_NONSTDC_NO_DEPRECATE",
942 ] 942 ]
943 } else if (is_clang && !is_nacl) {
944 # TODO(thakis): Remove !is_nacl once
945 # https://codereview.webrtc.org/1552863002/ made its way into chromium.
946 cflags += [ "-Wall" ]
943 } 947 }
944 948
945 if (is_linux) { 949 if (is_linux) {
946 # Don't warn about ignoring the return value from e.g. close(). This is 950 # Don't warn about ignoring the return value from e.g. close(). This is
947 # off by default in some gccs but on by default in others. BSD systems do 951 # off by default in some gccs but on by default in others. BSD systems do
948 # not support this option, since they are usually using gcc 4.2.1, which 952 # not support this option, since they are usually using gcc 4.2.1, which
949 # does not have this flag yet. 953 # does not have this flag yet.
950 cflags += [ "-Wno-unused-result" ] 954 cflags += [ "-Wno-unused-result" ]
951 } 955 }
952 956
(...skipping 350 matching lines...) Expand 10 before | Expand all | Expand 10 after
1303 if (symbol_level == 0) { 1307 if (symbol_level == 0) {
1304 configs = [ ":no_symbols" ] 1308 configs = [ ":no_symbols" ]
1305 } else if (symbol_level == 1) { 1309 } else if (symbol_level == 1) {
1306 configs = [ ":minimal_symbols" ] 1310 configs = [ ":minimal_symbols" ]
1307 } else if (symbol_level == 2) { 1311 } else if (symbol_level == 2) {
1308 configs = [ ":symbols" ] 1312 configs = [ ":symbols" ]
1309 } else { 1313 } else {
1310 assert(false) 1314 assert(false)
1311 } 1315 }
1312 } 1316 }
OLDNEW
« no previous file with comments | « build/common.gypi ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698