build/config/compiler/BUILD.gn - Issue 1555893002: Linux/CrOS/Cast/Android (and Mac with gn): Build 3rd-party code with -Wall.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/config/compiler/BUILD.gn

Issue 1555893002: Linux/CrOS/Cast/Android (and Mac with gn): Build 3rd-party code with -Wall. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/config/compiler/BUILD.gn

diff --git a/build/config/compiler/BUILD.gn b/build/config/compiler/BUILD.gn

index ef3fc3400b48a018e690048adf85c7da43ffc485..732f71aca18612ba8207512b5690e5004d8ab64d 100644

--- a/build/config/compiler/BUILD.gn

+++ b/build/config/compiler/BUILD.gn

@@ -940,6 +940,10 @@ config("no_chromium_code") {

"_CRT_NONSTDC_NO_WARNINGS",

"_CRT_NONSTDC_NO_DEPRECATE",

]

+ } else if (is_clang && !is_nacl) {

+ # TODO(thakis): Remove !is_nacl once

+ # https://codereview.webrtc.org/1552863002/ made its way into chromium.

+ cflags += [ "-Wall" ]

}

if (is_linux) {

« no previous file with comments | « build/common.gypi ('k') | no next file » | no next file with comments »