Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(534)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1548993002: Switch to standard integer types in base/strings/. (Closed)

Created:
4 years, 12 months ago by Avi (use Gerrit)
Modified:
4 years, 12 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews, jshin+watch_chromium.org, vmpstr+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Switch to standard integer types in base/strings/. BUG=138542 TBR=mark@chromium.org NOPRESUBMIT=true Committed: https://crrev.com/84f37e1ff5859e4ed7ece709c7101bde1138b3c1 Cr-Commit-Position: refs/heads/master@{#366860}

Patch Set 1 #

Patch Set 2 : build config #

Patch Set 3 : fix #

Patch Set 4 : fixes #

Patch Set 5 : more #

Patch Set 6 : #

Patch Set 7 : #

Patch Set 8 : #

Patch Set 9 : #

Patch Set 10 : #

Patch Set 11 : #

Patch Set 12 : #

Patch Set 13 : #

Patch Set 14 : #

Patch Set 15 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+242 lines, -160 lines) Patch
M base/i18n/icu_string_conversions_unittest.cc View 1 2 3 4 5 6 7 8 1 chunk +1 line, -0 lines 0 comments Download
M base/scoped_native_library.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M base/strings/latin1_string_conversions.h View 1 chunk +2 lines, -0 lines 0 comments Download
M base/strings/safe_sprintf.h View 1 chunk +0 lines, -1 line 0 comments Download
M base/strings/safe_sprintf.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M base/strings/safe_sprintf_unittest.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M base/strings/string16.h View 1 2 chunks +4 lines, -2 lines 0 comments Download
M base/strings/string_number_conversions.h View 4 chunks +15 lines, -13 lines 0 comments Download
M base/strings/string_number_conversions.cc View 12 chunks +36 lines, -38 lines 0 comments Download
M base/strings/string_number_conversions_unittest.cc View 9 chunks +9 lines, -7 lines 0 comments Download
M base/strings/string_piece.h View 1 chunk +0 lines, -1 line 0 comments Download
M base/strings/string_piece_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M base/strings/string_split.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M base/strings/string_split_unittest.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M base/strings/string_util.h View 2 chunks +4 lines, -2 lines 0 comments Download
M base/strings/string_util.cc View 1 chunk +1 line, -0 lines 0 comments Download
M base/strings/string_util_posix.h View 1 chunk +1 line, -0 lines 0 comments Download
M base/strings/string_util_unittest.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M base/strings/string_util_win.h View 1 chunk +1 line, -0 lines 0 comments Download
M base/strings/stringprintf.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M base/strings/stringprintf_unittest.cc View 1 chunk +3 lines, -1 line 0 comments Download
M base/strings/sys_string_conversions.h View 2 chunks +5 lines, -3 lines 0 comments Download
M base/strings/sys_string_conversions_mac.mm View 1 chunk +1 line, -0 lines 0 comments Download
M base/strings/sys_string_conversions_posix.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M base/strings/sys_string_conversions_unittest.cc View 1 chunk +4 lines, -1 line 0 comments Download
M base/strings/sys_string_conversions_win.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M base/strings/utf_offset_string_conversions.h View 1 chunk +2 lines, -0 lines 0 comments Download
M base/strings/utf_offset_string_conversions.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M base/strings/utf_offset_string_conversions_unittest.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M base/strings/utf_string_conversion_utils.h View 3 chunks +17 lines, -14 lines 0 comments Download
M base/strings/utf_string_conversion_utils.cc View 5 chunks +13 lines, -13 lines 0 comments Download
M base/strings/utf_string_conversions.h View 1 chunk +2 lines, -0 lines 0 comments Download
M base/strings/utf_string_conversions.cc View 1 2 chunks +6 lines, -3 lines 0 comments Download
M base/strings/utf_string_conversions_unittest.cc View 1 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/ui/app_list/search/search_resource_manager.h View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/passwords/account_chooser_more_combobox_model.h View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M chrome/installer/util/registry_entry.h View 1 2 3 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/installer/util/registry_entry.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/third_party/mozilla_security_manager/nsUsageArrayHelper.cpp View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M components/bookmarks/managed/managed_bookmarks_tracker.h View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +1 line, -0 lines 0 comments Download
M components/dom_distiller/webui/dom_distiller_ui.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +1 line, -0 lines 0 comments Download
M components/html_viewer/ime_controller.h View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -0 lines 0 comments Download
M components/os_crypt/os_crypt.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M components/proximity_auth/webui/proximity_auth_ui.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/gpu/gpu_internals_ui.h View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/webui/generic_handler.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +1 line, -0 lines 0 comments Download
M content/child/db_message_filter.h View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +1 line, -0 lines 0 comments Download
M content/child/indexed_db/mock_webidbcallbacks.h View 1 2 3 4 5 6 7 8 9 10 1 chunk +1 line, -0 lines 0 comments Download
M content/child/web_memory_allocator_dump_impl.h View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/renderer_clipboard_delegate.h View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +2 lines, -0 lines 0 comments Download
M content/shell/app/shell_crash_reporter_client.h View 1 2 3 4 5 6 7 8 9 10 1 chunk +2 lines, -0 lines 0 comments Download
M net/base/zap.cc View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M ppapi/shared_impl/ppb_gamepad_shared.cc View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M ppapi/shared_impl/private/ppb_char_set_shared.cc View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/CompositorProxy.cpp View 1 2 3 4 5 6 7 8 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/EditingBehavior.cpp View 1 2 3 4 5 6 7 8 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/events/UIEventWithKeyState.cpp View 1 2 3 4 5 6 7 8 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/fetch/ResourceTest.cpp View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/MixedContentCheckerTest.cpp View 1 2 3 4 5 6 7 8 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/notifications/NotificationDataTest.cpp View 1 2 3 4 5 6 7 8 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp View 1 2 3 4 5 6 7 8 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLCompressedTextureASTC.cpp View 1 2 3 4 5 6 7 8 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp View 1 2 3 4 5 6 7 8 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/exported/WebURLResponse.cpp View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridgeTest.cpp View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.cpp View 1 2 3 4 5 6 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/gpu/DrawingBufferTest.cpp View 1 2 3 4 5 6 7 8 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/network/ResourceResponse.h View 1 2 3 4 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/weborigin/DatabaseIdentifierTest.cpp View 1 2 3 4 5 6 7 8 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/weborigin/KURLTest.cpp View 1 2 3 4 5 6 7 8 6 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/weborigin/SecurityOrigin.cpp View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/weborigin/SecurityOriginTest.cpp View 1 2 3 4 5 6 7 8 5 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/web/AssociatedURLLoaderTest.cpp View 1 2 3 4 5 6 7 8 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/ChromeClientImpl.cpp View 1 2 3 4 5 6 7 8 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/public/platform/Platform.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/public/platform/WebExternalBitmap.h View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Issue 1538743002 Patch 100001

Messages

Total messages: 67 (34 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1548993002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1548993002/1
4 years, 12 months ago (2015-12-24 03:13:24 UTC) #2
commit-bot: I haz the power
Try jobs failed on following builders: ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ninja/builds/152812)
4 years, 12 months ago (2015-12-24 03:18:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1548993002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1548993002/20001
4 years, 12 months ago (2015-12-24 03:32:26 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/131452)
4 years, 12 months ago (2015-12-24 03:40:14 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1548993002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1548993002/40001
4 years, 12 months ago (2015-12-24 03:47:04 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/131458)
4 years, 12 months ago (2015-12-24 03:55:10 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1548993002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1548993002/60001
4 years, 12 months ago (2015-12-24 04:41:53 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/96381)
4 years, 12 months ago (2015-12-24 04:59:25 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1548993002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1548993002/80001
4 years, 12 months ago (2015-12-24 05:27:00 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/2561)
4 years, 12 months ago (2015-12-24 05:55:34 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1548993002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1548993002/100001
4 years, 12 months ago (2015-12-24 06:04:58 UTC) #23
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-generic_chromium_compile_only_ng/builds/73823)
4 years, 12 months ago (2015-12-24 06:24:06 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1548993002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1548993002/120001
4 years, 12 months ago (2015-12-24 06:29:33 UTC) #27
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-generic_chromium_compile_only_ng/builds/73863)
4 years, 12 months ago (2015-12-24 06:51:11 UTC) #29
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1548993002/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1548993002/140001
4 years, 12 months ago (2015-12-24 07:04:03 UTC) #31
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_android on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_android/builds/2381)
4 years, 12 months ago (2015-12-24 07:35:50 UTC) #33
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1548993002/160001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1548993002/160001
4 years, 12 months ago (2015-12-24 20:27:19 UTC) #35
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-generic_chromium_compile_only_ng/builds/73885)
4 years, 12 months ago (2015-12-24 20:53:37 UTC) #37
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1548993002/180001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1548993002/180001
4 years, 12 months ago (2015-12-24 21:06:39 UTC) #39
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_ng/builds/30710)
4 years, 12 months ago (2015-12-24 21:36:34 UTC) #41
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1548993002/200001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1548993002/200001
4 years, 12 months ago (2015-12-24 21:46:09 UTC) #43
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/153425)
4 years, 12 months ago (2015-12-24 23:16:59 UTC) #45
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1548993002/200001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1548993002/200001
4 years, 12 months ago (2015-12-25 01:52:29 UTC) #47
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/builds/83999)
4 years, 12 months ago (2015-12-25 03:19:20 UTC) #49
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1548993002/220001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1548993002/220001
4 years, 12 months ago (2015-12-25 05:08:14 UTC) #51
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-generic_chromium_compile_only_ng/builds/73948)
4 years, 12 months ago (2015-12-25 05:39:00 UTC) #53
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1548993002/240001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1548993002/240001
4 years, 12 months ago (2015-12-25 05:45:11 UTC) #55
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/96498)
4 years, 12 months ago (2015-12-25 06:14:34 UTC) #57
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1548993002/260001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1548993002/260001
4 years, 12 months ago (2015-12-25 06:35:12 UTC) #59
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_ng/builds/30741)
4 years, 12 months ago (2015-12-25 07:07:00 UTC) #61
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1548993002/280001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1548993002/280001
4 years, 12 months ago (2015-12-25 07:12:36 UTC) #63
commit-bot: I haz the power
Committed patchset #15 (id:280001)
4 years, 12 months ago (2015-12-25 09:31:51 UTC) #65
commit-bot: I haz the power
4 years, 12 months ago (2015-12-25 09:33:01 UTC) #67
Message was sent while issue was closed. 
Patchset 15 (id:??) landed as
https://crrev.com/84f37e1ff5859e4ed7ece709c7101bde1138b3c1
Cr-Commit-Position: refs/heads/master@{#366860}

Powered by Google App Engine
This is Rietveld 408576698