third_party/WebKit/Source/modules/notifications/NotificationDataTest.cpp - Issue 1548993002: Switch to standard integer types in base/strings/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/notifications/NotificationDataTest.cpp

Issue 1548993002: Switch to standard integer types in base/strings/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/loader/MixedContentCheckerTest.cpp ('k') | third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/notifications/NotificationDataTest.cpp

diff --git a/third_party/WebKit/Source/modules/notifications/NotificationDataTest.cpp b/third_party/WebKit/Source/modules/notifications/NotificationDataTest.cpp

index e4408be2530cd1cc86d1b68fc8db54ba8d87b7c6..45a7feba93301c3040ca52f56bc65c41e18069d1 100644

--- a/third_party/WebKit/Source/modules/notifications/NotificationDataTest.cpp

+++ b/third_party/WebKit/Source/modules/notifications/NotificationDataTest.cpp

@@ -49,7 +49,7 @@ private:

TEST_F(NotificationDataTest, ReflectProperties)

{

Vector<unsigned> vibrationPattern;

- for (size_t i = 0; i < arraysize(kNotificationVibration); ++i)

+ for (size_t i = 0; i < WTF_ARRAY_LENGTH(kNotificationVibration); ++i)

vibrationPattern.append(kNotificationVibration[i]);

UnsignedLongOrUnsignedLongSequence vibrationSequence;

@@ -102,7 +102,7 @@ TEST_F(NotificationDataTest, ReflectProperties)

TEST_F(NotificationDataTest, SilentNotificationWithVibration)

{

Vector<unsigned> vibrationPattern;

- for (size_t i = 0; i < arraysize(kNotificationVibration); ++i)

+ for (size_t i = 0; i < WTF_ARRAY_LENGTH(kNotificationVibration); ++i)

vibrationPattern.append(kNotificationVibration[i]);

UnsignedLongOrUnsignedLongSequence vibrationSequence;

@@ -134,7 +134,7 @@ TEST_F(NotificationDataTest, InvalidIconUrl)

TEST_F(NotificationDataTest, VibrationNormalization)

{

Vector<unsigned> unnormalizedPattern;

- for (size_t i = 0; i < arraysize(kNotificationVibrationUnnormalized); ++i)

+ for (size_t i = 0; i < WTF_ARRAY_LENGTH(kNotificationVibrationUnnormalized); ++i)

unnormalizedPattern.append(kNotificationVibrationUnnormalized[i]);

UnsignedLongOrUnsignedLongSequence vibrationSequence;

@@ -148,7 +148,7 @@ TEST_F(NotificationDataTest, VibrationNormalization)

EXPECT_FALSE(exceptionState.hadException());

Vector<int> normalizedPattern;

- for (size_t i = 0; i < arraysize(kNotificationVibrationNormalized); ++i)

+ for (size_t i = 0; i < WTF_ARRAY_LENGTH(kNotificationVibrationNormalized); ++i)

normalizedPattern.append(kNotificationVibrationNormalized[i]);

ASSERT_EQ(normalizedPattern.size(), notificationData.vibrate.size());