Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 1547233002: Convert Pass()→std::move() in //google_apis (Closed)

Created:
4 years, 11 months ago by dcheng
Modified:
4 years, 11 months ago
CC:
chromium-reviews, zea+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert Pass()→std::move() in //google_apis ❆(੭ु ◜◡‾)੭ु⁾☃❆ BUG=557422 R=avi@chromium.org TBR=rogerta@chromium.org Committed: https://crrev.com/039a7365a80655d3ab1f37a450e6e81a54c7db6c Cr-Commit-Position: refs/heads/master@{#366938}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+164 lines, -165 lines) Patch
M google_apis/drive/base_requests.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M google_apis/drive/base_requests_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M google_apis/drive/drive_api_parser.h View 4 chunks +8 lines, -12 lines 0 comments Download
M google_apis/drive/drive_api_parser.cc View 11 chunks +11 lines, -11 lines 0 comments Download
M google_apis/drive/drive_api_requests.h View 2 chunks +2 lines, -2 lines 0 comments Download
M google_apis/drive/drive_api_requests.cc View 4 chunks +4 lines, -3 lines 0 comments Download
M google_apis/drive/drive_api_requests_unittest.cc View 11 chunks +12 lines, -10 lines 0 comments Download
M google_apis/drive/files_list_request_runner.cc View 2 chunks +3 lines, -1 line 0 comments Download
M google_apis/drive/request_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M google_apis/drive/test_util.h View 1 chunk +1 line, -1 line 0 comments Download
M google_apis/drive/test_util.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M google_apis/gaia/fake_gaia.cc View 2 chunks +2 lines, -1 line 0 comments Download
M google_apis/gaia/gaia_oauth_client.cc View 4 chunks +6 lines, -4 lines 0 comments Download
M google_apis/gaia/oauth2_token_service.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M google_apis/gaia/oauth2_token_service_request.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M google_apis/gcm/base/mcs_message.cc View 4 chunks +6 lines, -4 lines 0 comments Download
M google_apis/gcm/base/mcs_message_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M google_apis/gcm/base/mcs_util.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M google_apis/gcm/engine/connection_factory_impl.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M google_apis/gcm/engine/connection_factory_impl_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M google_apis/gcm/engine/connection_handler_impl.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M google_apis/gcm/engine/connection_handler_impl_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M google_apis/gcm/engine/fake_connection_handler.cc View 2 chunks +3 lines, -1 line 0 comments Download
M google_apis/gcm/engine/gcm_store_impl.cc View 5 chunks +7 lines, -7 lines 0 comments Download
M google_apis/gcm/engine/gcm_store_impl_unittest.cc View 24 chunks +25 lines, -25 lines 0 comments Download
M google_apis/gcm/engine/heartbeat_manager.cc View 2 chunks +3 lines, -1 line 0 comments Download
M google_apis/gcm/engine/mcs_client.cc View 6 chunks +9 lines, -11 lines 0 comments Download
M google_apis/gcm/engine/mcs_client_unittest.cc View 10 chunks +13 lines, -10 lines 0 comments Download
M google_apis/gcm/engine/registration_request.cc View 2 chunks +2 lines, -1 line 0 comments Download
M google_apis/gcm/engine/registration_request_unittest.cc View 3 chunks +5 lines, -14 lines 0 comments Download
M google_apis/gcm/engine/unregistration_request.cc View 2 chunks +3 lines, -1 line 0 comments Download
M google_apis/gcm/engine/unregistration_request_unittest.cc View 3 chunks +5 lines, -13 lines 0 comments Download
M google_apis/gcm/tools/mcs_probe.cc View 4 chunks +6 lines, -9 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
dcheng
+avi for sanity check / general review +rogerta for owners review
4 years, 11 months ago (2015-12-27 20:59:07 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1547233002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1547233002/1
4 years, 11 months ago (2015-12-27 20:59:30 UTC) #4
Avi (use Gerrit)
lgtm stampity stamp
4 years, 11 months ago (2015-12-27 21:22:21 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2015-12-27 22:08:49 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1547233002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1547233002/1
4 years, 11 months ago (2015-12-27 22:12:05 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2015-12-27 22:16:58 UTC) #10
commit-bot: I haz the power
4 years, 11 months ago (2015-12-27 22:18:07 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/039a7365a80655d3ab1f37a450e6e81a54c7db6c
Cr-Commit-Position: refs/heads/master@{#366938}

Powered by Google App Engine
This is Rietveld 408576698