google_apis/gcm/engine/connection_factory_impl.cc - Issue 1547233002: Convert Pass()→std::move() in //google_apis

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: google_apis/gcm/engine/connection_factory_impl.cc

Issue 1547233002: Convert Pass()→std::move() in //google_apis (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: google_apis/gcm/engine/connection_factory_impl.cc

diff --git a/google_apis/gcm/engine/connection_factory_impl.cc b/google_apis/gcm/engine/connection_factory_impl.cc

index 19f456c39869b5930b3d1613afb5a43c4b2e7cf3..43bac40cd4d4a778b588be09f57e2be8849bf48a 100644

--- a/google_apis/gcm/engine/connection_factory_impl.cc

+++ b/google_apis/gcm/engine/connection_factory_impl.cc

@@ -107,11 +107,10 @@ ConnectionHandler* ConnectionFactoryImpl::GetConnectionHandler() const {

void ConnectionFactoryImpl::Connect() {

if (!connection_handler_) {

connection_handler_ = CreateConnectionHandler(

- base::TimeDelta::FromMilliseconds(kReadTimeoutMs),

- read_callback_,

+ base::TimeDelta::FromMilliseconds(kReadTimeoutMs), read_callback_,

write_callback_,

base::Bind(&ConnectionFactoryImpl::ConnectionHandlerCallback,

- weak_ptr_factory_.GetWeakPtr())).Pass();

+ weak_ptr_factory_.GetWeakPtr()));

}

if (connecting_ || waiting_for_backoff_)