google_apis/gcm/engine/connection_factory_impl_unittest.cc - Issue 1547233002: Convert Pass()→std::move() in //google_apis

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: google_apis/gcm/engine/connection_factory_impl_unittest.cc

Issue 1547233002: Convert Pass()→std::move() in //google_apis (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: google_apis/gcm/engine/connection_factory_impl_unittest.cc

diff --git a/google_apis/gcm/engine/connection_factory_impl_unittest.cc b/google_apis/gcm/engine/connection_factory_impl_unittest.cc

index 7e8bc02e63f913c27e8c66adbe18707070cf9a81..56ed855ef573fc82c15b9f01613704e17ab455fe 100644

--- a/google_apis/gcm/engine/connection_factory_impl_unittest.cc

+++ b/google_apis/gcm/engine/connection_factory_impl_unittest.cc

@@ -5,6 +5,7 @@

#include "google_apis/gcm/engine/connection_factory_impl.h"

#include <cmath>

+#include <utility>

#include "base/message_loop/message_loop.h"

#include "base/run_loop.h"

@@ -201,7 +202,7 @@ TestConnectionFactoryImpl::CreateConnectionHandler(

const ConnectionHandler::ProtoReceivedCallback& read_callback,

const ConnectionHandler::ProtoSentCallback& write_callback,

const ConnectionHandler::ConnectionChangedCallback& connection_callback) {

- return scoped_handler_.Pass();

+ return std::move(scoped_handler_);

}

base::TimeTicks TestConnectionFactoryImpl::NowTicks() {