Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Side by Side Diff: google_apis/gcm/engine/unregistration_request_unittest.cc

Issue 1547233002: Convert Pass()→std::move() in //google_apis (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « google_apis/gcm/engine/unregistration_request.cc ('k') | google_apis/gcm/tools/mcs_probe.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <stdint.h> 5 #include <stdint.h>
6
7 #include <map> 6 #include <map>
8 #include <string> 7 #include <string>
8 #include <utility>
9 #include <vector> 9 #include <vector>
10 10
11 #include "base/strings/string_number_conversions.h" 11 #include "base/strings/string_number_conversions.h"
12 #include "base/strings/string_tokenizer.h" 12 #include "base/strings/string_tokenizer.h"
13 #include "google_apis/gcm/engine/gcm_request_test_base.h" 13 #include "google_apis/gcm/engine/gcm_request_test_base.h"
14 #include "google_apis/gcm/engine/gcm_unregistration_request_handler.h" 14 #include "google_apis/gcm/engine/gcm_unregistration_request_handler.h"
15 #include "google_apis/gcm/engine/instance_id_delete_token_request_handler.h" 15 #include "google_apis/gcm/engine/instance_id_delete_token_request_handler.h"
16 #include "google_apis/gcm/monitoring/fake_gcm_stats_recorder.h" 16 #include "google_apis/gcm/monitoring/fake_gcm_stats_recorder.h"
17 #include "net/base/load_flags.h" 17 #include "net/base/load_flags.h"
18 18
(...skipping 70 matching lines...) Expand 10 before | Expand all | Expand 10 after
89 89
90 GCMUnregistrationRequestTest::~GCMUnregistrationRequestTest() { 90 GCMUnregistrationRequestTest::~GCMUnregistrationRequestTest() {
91 } 91 }
92 92
93 void GCMUnregistrationRequestTest::CreateRequest() { 93 void GCMUnregistrationRequestTest::CreateRequest() {
94 UnregistrationRequest::RequestInfo request_info( 94 UnregistrationRequest::RequestInfo request_info(
95 kAndroidId, kSecurityToken, kAppId); 95 kAndroidId, kSecurityToken, kAppId);
96 scoped_ptr<GCMUnregistrationRequestHandler> request_handler( 96 scoped_ptr<GCMUnregistrationRequestHandler> request_handler(
97 new GCMUnregistrationRequestHandler(kAppId)); 97 new GCMUnregistrationRequestHandler(kAppId));
98 request_.reset(new UnregistrationRequest( 98 request_.reset(new UnregistrationRequest(
99 GURL(kRegistrationURL), 99 GURL(kRegistrationURL), request_info, std::move(request_handler),
100 request_info,
101 request_handler.Pass(),
102 GetBackoffPolicy(), 100 GetBackoffPolicy(),
103 base::Bind(&UnregistrationRequestTest::UnregistrationCallback, 101 base::Bind(&UnregistrationRequestTest::UnregistrationCallback,
104 base::Unretained(this)), 102 base::Unretained(this)),
105 max_retry_count_, 103 max_retry_count_, url_request_context_getter(), &recorder_,
106 url_request_context_getter(),
107 &recorder_,
108 std::string())); 104 std::string()));
109 } 105 }
110 106
111 TEST_F(GCMUnregistrationRequestTest, RequestDataPassedToFetcher) { 107 TEST_F(GCMUnregistrationRequestTest, RequestDataPassedToFetcher) {
112 CreateRequest(); 108 CreateRequest();
113 request_->Start(); 109 request_->Start();
114 110
115 // Get data sent by request. 111 // Get data sent by request.
116 net::TestURLFetcher* fetcher = GetFetcher(); 112 net::TestURLFetcher* fetcher = GetFetcher();
117 ASSERT_TRUE(fetcher); 113 ASSERT_TRUE(fetcher);
(...skipping 224 matching lines...) Expand 10 before | Expand all | Expand 10 after
342 void InstaceIDDeleteTokenRequestTest::CreateRequest( 338 void InstaceIDDeleteTokenRequestTest::CreateRequest(
343 const std::string& instance_id, 339 const std::string& instance_id,
344 const std::string& authorized_entity, 340 const std::string& authorized_entity,
345 const std::string& scope) { 341 const std::string& scope) {
346 UnregistrationRequest::RequestInfo request_info( 342 UnregistrationRequest::RequestInfo request_info(
347 kAndroidId, kSecurityToken, kAppId); 343 kAndroidId, kSecurityToken, kAppId);
348 scoped_ptr<InstanceIDDeleteTokenRequestHandler> request_handler( 344 scoped_ptr<InstanceIDDeleteTokenRequestHandler> request_handler(
349 new InstanceIDDeleteTokenRequestHandler( 345 new InstanceIDDeleteTokenRequestHandler(
350 instance_id, authorized_entity, scope, kGCMVersion)); 346 instance_id, authorized_entity, scope, kGCMVersion));
351 request_.reset(new UnregistrationRequest( 347 request_.reset(new UnregistrationRequest(
352 GURL(kRegistrationURL), 348 GURL(kRegistrationURL), request_info, std::move(request_handler),
353 request_info,
354 request_handler.Pass(),
355 GetBackoffPolicy(), 349 GetBackoffPolicy(),
356 base::Bind(&UnregistrationRequestTest::UnregistrationCallback, 350 base::Bind(&UnregistrationRequestTest::UnregistrationCallback,
357 base::Unretained(this)), 351 base::Unretained(this)),
358 max_retry_count(), 352 max_retry_count(), url_request_context_getter(), &recorder_,
359 url_request_context_getter(),
360 &recorder_,
361 std::string())); 353 std::string()));
362 } 354 }
363 355
364 TEST_F(InstaceIDDeleteTokenRequestTest, RequestDataPassedToFetcher) { 356 TEST_F(InstaceIDDeleteTokenRequestTest, RequestDataPassedToFetcher) {
365 CreateRequest(kInstanceId, kDeveloperId, kScope); 357 CreateRequest(kInstanceId, kDeveloperId, kScope);
366 request_->Start(); 358 request_->Start();
367 359
368 // Get data sent by request. 360 // Get data sent by request.
369 net::TestURLFetcher* fetcher = GetFetcher(); 361 net::TestURLFetcher* fetcher = GetFetcher();
370 ASSERT_TRUE(fetcher); 362 ASSERT_TRUE(fetcher);
(...skipping 86 matching lines...) Expand 10 before | Expand all | Expand 10 after
457 request_->Start(); 449 request_->Start();
458 450
459 SetResponse(net::HTTP_OK, "Error=XXX"); 451 SetResponse(net::HTTP_OK, "Error=XXX");
460 CompleteFetch(); 452 CompleteFetch();
461 453
462 EXPECT_TRUE(callback_called_); 454 EXPECT_TRUE(callback_called_);
463 EXPECT_EQ(UnregistrationRequest::UNKNOWN_ERROR, status_); 455 EXPECT_EQ(UnregistrationRequest::UNKNOWN_ERROR, status_);
464 } 456 }
465 457
466 } // namespace gcm 458 } // namespace gcm
OLDNEW
« no previous file with comments | « google_apis/gcm/engine/unregistration_request.cc ('k') | google_apis/gcm/tools/mcs_probe.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698