Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Unified Diff: google_apis/drive/base_requests.cc

Issue 1547233002: Convert Pass()→std::move() in //google_apis (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | google_apis/drive/base_requests_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: google_apis/drive/base_requests.cc
diff --git a/google_apis/drive/base_requests.cc b/google_apis/drive/base_requests.cc
index a1981387e755e365bd99b26b8d8aac396f5c5d1e..3e5b0d1d4c75754b0ddc52eeed4fb6cd51e0aa94 100644
--- a/google_apis/drive/base_requests.cc
+++ b/google_apis/drive/base_requests.cc
@@ -5,6 +5,7 @@
#include "google_apis/drive/base_requests.h"
#include <stddef.h>
+#include <utility>
#include "base/files/file_util.h"
#include "base/json/json_reader.h"
@@ -214,7 +215,7 @@ scoped_ptr<base::Value> ParseJson(const std::string& json) {
LOG(WARNING) << "Error while parsing entry response: " << error_message
<< ", code: " << error_code << ", json:\n" << trimmed_json;
}
- return value.Pass();
+ return value;
}
void GenerateMultipartBody(MultipartType multipart_type,
@@ -742,7 +743,7 @@ void UploadRangeRequestBase::OnDataParsed(DriveApiErrorCode code,
DCHECK(CalledOnValidThread());
DCHECK(code == HTTP_CREATED || code == HTTP_SUCCESS);
- OnRangeRequestComplete(UploadRangeResponse(code, -1, -1), value.Pass());
+ OnRangeRequestComplete(UploadRangeResponse(code, -1, -1), std::move(value));
OnProcessURLFetchResultsComplete();
}
« no previous file with comments | « no previous file | google_apis/drive/base_requests_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698