Revert of Enable presubmit pylint in build/android.

Revert of Enable presubmit pylint in build/android. (https://codereview.chromium.org/132463007/)

Reason for revert:
This patch is probably the cause of crbug.com/342539.

Original issue's description:
> Enable presubmit pylint in build/android.
> 
> BUG=168518
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=249793

TBR=craigdh@chromium.org,frankf@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=168518
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=250269

[jbudorick, 2014-02-11 01:15:16]

Created Revert of Enable presubmit pylint in build/android.

[commit-bot: I haz the power, 2014-02-11 01:16:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-11 01:16:14]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a lowly provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[craigdh, 2014-02-11 01:17:18]

On 2014/02/11 01:16:14, I haz the power (commit-bot) wrote:
> No LGTM from a valid reviewer yet. Only full committers are accepted.
> Even if an LGTM may have been provided, it was from a non-committer or
> a lowly provisional committer, _not_ a full super star committer.
> See http://www.chromium.org/getting-involved/become-a-committer
> Note that this has nothing to do with OWNERS files.

lgtm.

[jbudorick, 2014-02-11 01:22:44]

The CQ bit was checked by jbudorick@chromium.org

[commit-bot: I haz the power, 2014-02-11 01:24:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jbudorick@chromium.org/153743008/1

[commit-bot: I haz the power, 2014-02-11 01:24:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-11 01:24:47]

Failed to apply patch for build/android/pylib/linker/test_case.py:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file build/android/pylib/linker/test_case.py
  Hunk #1 FAILED at 33.
  1 out of 6 hunks FAILED -- saving rejects to file
build/android/pylib/linker/test_case.py.rej

Patch:       build/android/pylib/linker/test_case.py
Index: build/android/pylib/linker/test_case.py
diff --git a/build/android/pylib/linker/test_case.py
b/build/android/pylib/linker/test_case.py
index
febab92545ca8b8637da80833db5f97e15adebf5..b4bddc727c749c0cd5979860f45518360397203f
100644
--- a/build/android/pylib/linker/test_case.py
+++ b/build/android/pylib/linker/test_case.py
@@ -33,34 +33,36 @@
      build/android/test_runner.py linker
 
 """
-# pylint: disable=R0201
 
 import logging
 import os
 import re
+import StringIO
+import subprocess
+import tempfile
 import time
 
 from pylib import constants
 from pylib import android_commands
+from pylib import flag_changer
 from pylib.base import base_test_result
 
-
 ResultType = base_test_result.ResultType
 
-_PACKAGE_NAME = 'org.chromium.content_linker_test_apk'
-_ACTIVITY_NAME = '.ContentLinkerTestActivity'
-_COMMAND_LINE_FILE = '/data/local/tmp/content-linker-test-command-line'
+_PACKAGE_NAME='org.chromium.content_linker_test_apk'
+_ACTIVITY_NAME='.ContentLinkerTestActivity'
+_COMMAND_LINE_FILE='/data/local/tmp/content-linker-test-command-line'
 
 # Path to the Linker.java source file.
-_LINKER_JAVA_SOURCE_PATH = (
-    'content/public/android/java/src/org/chromium/content/app/Linker.java')
+_LINKER_JAVA_SOURCE_PATH = \
+    'content/public/android/java/src/org/chromium/content/app/Linker.java'
 
 # A regular expression used to extract the browser shared RELRO configuration
 # from the Java source file above.
-_RE_LINKER_BROWSER_CONFIG = re.compile(
-    r'.*BROWSER_SHARED_RELRO_CONFIG\s+=\s+' +
-        'BROWSER_SHARED_RELRO_CONFIG_(\S+)\s*;.*',
-    re.MULTILINE | re.DOTALL)
+_RE_LINKER_BROWSER_CONFIG = \
+    re.compile(r'.*BROWSER_SHARED_RELRO_CONFIG\s+=\s+' + \
+               'BROWSER_SHARED_RELRO_CONFIG_(\S+)\s*;.*',
+               re.MULTILINE | re.DOTALL)
 
 # Logcat filters used during each test. Only the 'chromium' one is really
 # needed, but the logs are added to the TestResult in case of error, and
@@ -148,7 +150,7 @@
   return (False, None, None)
 
 
-def _WaitForLinkerTestStatus(_adb, _timeout):
+def _WaitForLinkerTestStatus(adb, timeout):
   """Wait up to |timeout| seconds until the full linker test status lines
appear
      in the logcat being recorded with |adb|.
   Args:
@@ -159,7 +161,6 @@
     ResultType.TIMEOUT in case of timeout, ResulType.PASS if both status lines
     report 'SUCCESS', or ResulType.FAIL otherwise.
   """
-  pass
 
 
 def _StartActivityAndWaitForLinkerTestStatus(adb, timeout):
@@ -275,6 +276,7 @@
 
   # For each library, check the randomness of its load addresses.
   bad_libs = {}
+  success = True
   for lib_name, lib_address_list in lib_addr_map.iteritems():
     # If all addresses are different, skip to next item.
     lib_address_set = set(lib_address_list)
@@ -302,17 +304,17 @@
     """
     self.is_low_memory = is_low_memory
     if is_low_memory:
-      test_suffix = 'ForLowMemoryDevice'
+        test_suffix = 'ForLowMemoryDevice'
     else:
-      test_suffix = 'ForRegularDevice'
+        test_suffix = 'ForRegularDevice'
     class_name = self.__class__.__name__
     self.qualified_name = '%s.%s' % (class_name, test_suffix)
     self.tagged_name = self.qualified_name
 
-  def _RunTest(self, _adb):
+  def _RunTest(self, adb):
     """Run the test, must be overriden.
     Args:
-      _adb: An AndroidCommands instance to the device.
+      adb: An AndroidCommands instance to the device.
     Returns:
       A (status, log) tuple, where <status> is a ResultType constant, and <log>
       is the logcat output captured during the test in case of error, or None
@@ -497,7 +499,7 @@
     browser_lib_map_list = []
     renderer_lib_map_list = []
     logs_list = []
-    for _loop in range(max_loops):
+    for loop in range(max_loops):
       # Start the activity.
       result, logs = _StartActivityAndWaitForLinkerTestStatus(adb, timeout=30)
       if result == ResultType.TIMEOUT:

[jbudorick, 2014-02-11 01:42:29]

The CQ bit was checked by jbudorick@chromium.org

[commit-bot: I haz the power, 2014-02-11 01:43:57]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jbudorick@chromium.org/153743008/200001

[commit-bot: I haz the power, 2014-02-11 01:47:46]

Change committed as 250269