build/android/pylib/gtest/test_package_exe.py - Issue 153743008: Revert of Enable presubmit pylint in build/android.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/pylib/gtest/test_package_exe.py

Issue 153743008: Revert of Enable presubmit pylint in build/android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Merging with changes to pylib/linker/test_case.py. Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/android/pylib/gtest/test_package_exe.py

diff --git a/build/android/pylib/gtest/test_package_exe.py b/build/android/pylib/gtest/test_package_exe.py

index 69a7b07524c032b63ee4c5be0adcdd9c1b08002b..54aed9194078cf447434779ac605425c3aa25371 100644

--- a/build/android/pylib/gtest/test_package_exe.py

+++ b/build/android/pylib/gtest/test_package_exe.py

@@ -12,7 +12,8 @@ import tempfile

from pylib import cmd_helper

from pylib import constants

from pylib import pexpect

-from pylib.gtest.test_package import TestPackage

+from test_package import TestPackage

class TestPackageExecutable(TestPackage):

@@ -51,8 +52,7 @@ class TestPackageExecutable(TestPackage):

ret = 1

return ret

- @staticmethod

- def _AddNativeCoverageExports(adb):

+ def _AddNativeCoverageExports(self, adb):

# export GCOV_PREFIX set the path for native coverage results

# export GCOV_PREFIX_STRIP indicates how many initial directory

# names to strip off the hardwired absolute paths.