Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1268)

Side by Side Diff: build/android/pylib/constants.py

Issue 153743008: Revert of Enable presubmit pylint in build/android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Merging with changes to pylib/linker/test_case.py. Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « build/android/pylib/cmd_helper.py ('k') | build/android/pylib/device/adb_wrapper.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Defines a set of constants shared by test runners and other scripts.""" 5 """Defines a set of constants shared by test runners and other scripts."""
6 # pylint: disable=W0212
7 6
8 import collections 7 import collections
9 import logging 8 import logging
10 import os 9 import os
11 import subprocess 10 import subprocess
11 import sys
12 12
13 13
14 DIR_SOURCE_ROOT = os.path.abspath(os.path.join(os.path.dirname(__file__), 14 DIR_SOURCE_ROOT = os.path.abspath(os.path.join(os.path.dirname(__file__),
15 os.pardir, os.pardir, os.pardir)) 15 os.pardir, os.pardir, os.pardir))
16 ISOLATE_DEPS_DIR = os.path.join(DIR_SOURCE_ROOT, 'isolate_deps_dir') 16 ISOLATE_DEPS_DIR = os.path.join(DIR_SOURCE_ROOT, 'isolate_deps_dir')
17 17
18 CHROMIUM_TEST_SHELL_HOST_DRIVEN_DIR = os.path.join( 18 CHROMIUM_TEST_SHELL_HOST_DRIVEN_DIR = os.path.join(
19 DIR_SOURCE_ROOT, 'chrome', 'android') 19 DIR_SOURCE_ROOT, 'chrome', 'android')
20 20
21 21
(...skipping 160 matching lines...) Expand 10 before | Expand all | Expand 10 after
182 subprocess.call(['adb', 'version'], stdout=devnull, stderr=devnull) 182 subprocess.call(['adb', 'version'], stdout=devnull, stderr=devnull)
183 return 'adb' 183 return 'adb'
184 except OSError: 184 except OSError:
185 logging.debug('No adb found in $PATH, fallback to checked in binary.') 185 logging.debug('No adb found in $PATH, fallback to checked in binary.')
186 return os.path.join(ANDROID_SDK_ROOT, 'platform-tools', 'adb') 186 return os.path.join(ANDROID_SDK_ROOT, 'platform-tools', 'adb')
187 187
188 188
189 # Exit codes 189 # Exit codes
190 ERROR_EXIT_CODE = 1 190 ERROR_EXIT_CODE = 1
191 WARNING_EXIT_CODE = 88 191 WARNING_EXIT_CODE = 88
OLDNEW
« no previous file with comments | « build/android/pylib/cmd_helper.py ('k') | build/android/pylib/device/adb_wrapper.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698