build/android/pylib/utils/xvfb.py - Issue 153743008: Revert of Enable presubmit pylint in build/android.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: build/android/pylib/utils/xvfb.py

Issue 153743008: Revert of Enable presubmit pylint in build/android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Merging with changes to pylib/linker/test_case.py. Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.	1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 # pylint: disable=W0702

6

7 import os	5 import os

8 import signal	6 import signal

9 import subprocess	7 import subprocess

10 import sys	8 import sys

11 import time	9 import time

12	10

13	11

14 def _IsLinux():	12 def _IsLinux():

15 """Return True if on Linux; else False."""	13 """Return True if on Linux; else False."""

16 return sys.platform.startswith('linux')	14 return sys.platform.startswith('linux')

(...skipping 32 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
49	47

50 def Stop(self):	48 def Stop(self):

51 """Stop Xvfb if needed. Linux only."""	49 """Stop Xvfb if needed. Linux only."""

52 if self._pid:	50 if self._pid:

53 try:	51 try:

54 os.kill(self._pid, signal.SIGKILL)	52 os.kill(self._pid, signal.SIGKILL)

55 except:	53 except:

56 pass	54 pass

57 del os.environ['DISPLAY']	55 del os.environ['DISPLAY']

58 self._pid = 0	56 self._pid = 0

OLD	NEW