| OLD | NEW |
| 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. | 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. |
| 2 # Use of this source code is governed by a BSD-style license that can be | 2 # Use of this source code is governed by a BSD-style license that can be |
| 3 # found in the LICENSE file. | 3 # found in the LICENSE file. |
| 4 | 4 |
| 5 """Presubmit script for android buildbot. | 5 """Presubmit script for android buildbot. |
| 6 | 6 |
| 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts for | 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts for |
| 8 details on the presubmit API built into gcl. | 8 details on the presubmit API built into gcl. |
| 9 """ | 9 """ |
| 10 | 10 |
| (...skipping 17 matching lines...) Expand all Loading... |
| 28 return results | 28 return results |
| 29 | 29 |
| 30 | 30 |
| 31 def CommonChecks(input_api, output_api): | 31 def CommonChecks(input_api, output_api): |
| 32 output = [] | 32 output = [] |
| 33 | 33 |
| 34 def J(*dirs): | 34 def J(*dirs): |
| 35 """Returns a path relative to presubmit directory.""" | 35 """Returns a path relative to presubmit directory.""" |
| 36 return input_api.os_path.join(input_api.PresubmitLocalPath(), *dirs) | 36 return input_api.os_path.join(input_api.PresubmitLocalPath(), *dirs) |
| 37 | 37 |
| 38 # F0401 is issued when pylint can't import a module, but it doesn't seem to | |
| 39 # work correctly on our scripts. | |
| 40 output.extend(input_api.canned_checks.RunPylint( | 38 output.extend(input_api.canned_checks.RunPylint( |
| 41 input_api, | 39 input_api, |
| 42 output_api, | 40 output_api, |
| 43 white_list=[r'.*\.py$'], | 41 white_list=[r'PRESUBMIT\.py$', r'buildbot/.*\.py$'], |
| 44 black_list=[r'pylib/android_commands\.py$'], | |
| 45 extra_paths_list=[ | 42 extra_paths_list=[ |
| 46 J(), J('..', '..', 'third_party', 'android_testrunner'), | 43 J(), J('..', '..', 'third_party', 'android_testrunner'), |
| 47 J('buildbot')])) | 44 J('buildbot')])) |
| 48 | 45 |
| 49 output.extend(input_api.canned_checks.RunUnitTestsInDirectory( | 46 output.extend(input_api.canned_checks.RunUnitTestsInDirectory( |
| 50 input_api, output_api, J('buildbot', 'tests'))) | 47 input_api, output_api, J('buildbot', 'tests'))) |
| 51 output.extend(_CheckDeletionsOnlyFiles(input_api, output_api)) | 48 output.extend(_CheckDeletionsOnlyFiles(input_api, output_api)) |
| 52 return output | 49 return output |
| 53 | 50 |
| 54 | 51 |
| 55 def CheckChangeOnUpload(input_api, output_api): | 52 def CheckChangeOnUpload(input_api, output_api): |
| 56 return CommonChecks(input_api, output_api) | 53 return CommonChecks(input_api, output_api) |
| 57 | 54 |
| 58 | 55 |
| 59 def CheckChangeOnCommit(input_api, output_api): | 56 def CheckChangeOnCommit(input_api, output_api): |
| 60 return CommonChecks(input_api, output_api) | 57 return CommonChecks(input_api, output_api) |
| OLD | NEW |