Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 1534813003: Use C bindings to Mojo GL entry points exclusively. (Closed)

Created:
5 years ago by jeffbrown
Modified:
4 years, 11 months ago
Reviewers:
jamesr, viettrungluu, abarth
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, darin (slow to review), gregsimon, mojo-reviews_chromium.org, qsr+mojo_chromium.org, smklein, viettrungluu+watch_chromium.org
Base URL:
git@github.com:domokit/mojo.git@moz-6
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Use C bindings to Mojo GL entry points exclusively. Backported from the Sky repository. This change eliminates dependencies on the GPU service implementation from client applications. BUG= Review URL: https://codereview.chromium.org/1534893002 . R=jamesr@chromium.org, abarth, jamesr, viettrungluu Committed: https://chromium.googlesource.com/external/mojo/+/4e48bc26f74e4de175597ea16c57b96ad574839d

Patch Set 1 #

Patch Set 2 : fix include order #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -2834 lines) Patch
M gpu/command_buffer/build_gles2_cmd_buffer.py View 4 chunks +0 lines, -113 lines 0 comments Download
D gpu/skia_bindings/BUILD.gn View 1 chunk +0 lines, -14 lines 0 comments Download
D gpu/skia_bindings/gl_bindings_skia_cmd_buffer.h View 1 chunk +0 lines, -20 lines 0 comments Download
D gpu/skia_bindings/gl_bindings_skia_cmd_buffer.cc View 1 chunk +0 lines, -155 lines 0 comments Download
M mojo/gpu/BUILD.gn View 2 chunks +1 line, -6 lines 0 comments Download
M mojo/gpu/gl_context.h View 3 chunks +2 lines, -12 lines 0 comments Download
M mojo/gpu/gl_context.cc View 1 3 chunks +5 lines, -6 lines 0 comments Download
D mojo/gpu/mojo_context_support.h View 1 chunk +0 lines, -41 lines 0 comments Download
D mojo/gpu/mojo_context_support.cc View 1 chunk +0 lines, -71 lines 0 comments Download
D mojo/gpu/mojo_gles2_impl_autogen.h View 1 chunk +0 lines, -758 lines 0 comments Download
D mojo/gpu/mojo_gles2_impl_autogen.cc View 1 chunk +0 lines, -1599 lines 0 comments Download
M mojo/skia/BUILD.gn View 2 chunks +16 lines, -3 lines 0 comments Download
M mojo/skia/ganesh_context.cc View 4 chunks +4 lines, -14 lines 0 comments Download
A + mojo/skia/gl_bindings_skia.h View 2 chunks +6 lines, -6 lines 0 comments Download
A + mojo/skia/gl_bindings_skia.cc View 2 chunks +13 lines, -16 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 7 (1 generated)
jeffbrown
5 years ago (2015-12-17 22:02:35 UTC) #1
jeffbrown
Can you take a look at this one next? It'll help Sean Klein with his ...
4 years, 11 months ago (2016-01-07 20:22:32 UTC) #2
viettrungluu
On 2016/01/07 20:22:32, jeffbrown wrote: > Can you take a look at this one next? ...
4 years, 11 months ago (2016-01-12 16:49:43 UTC) #3
jamesr
lgtm
4 years, 11 months ago (2016-01-12 18:31:09 UTC) #4
jeffbrown
rebase
4 years, 11 months ago (2016-01-26 08:56:33 UTC) #5
jeffbrown
4 years, 11 months ago (2016-01-26 23:49:43 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
4e48bc26f74e4de175597ea16c57b96ad574839d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698