Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1163)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1534893002: Use C bindings to Mojo GL entry points exclusively. (Closed)

Created:
5 years ago by jeffbrown
Modified:
5 years ago
Reviewers:
abarth, jamesr
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@cl-2f
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Use C bindings to Mojo GL entry points exclusively. Backported from the Sky repository. This change eliminates dependencies on the GPU service implementation from client applications. BUG= Committed: https://chromium.googlesource.com/external/mojo/+/a7b1f93652cb7cecc30a46e1e160ada14397457c

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -2835 lines) Patch
M gpu/command_buffer/build_gles2_cmd_buffer.py View 4 chunks +0 lines, -113 lines 0 comments Download
D gpu/skia_bindings/BUILD.gn View 1 chunk +0 lines, -14 lines 0 comments Download
D gpu/skia_bindings/gl_bindings_skia_cmd_buffer.h View 1 chunk +0 lines, -20 lines 0 comments Download
D gpu/skia_bindings/gl_bindings_skia_cmd_buffer.cc View 1 chunk +0 lines, -155 lines 0 comments Download
M mojo/gpu/BUILD.gn View 2 chunks +1 line, -6 lines 0 comments Download
M mojo/gpu/gl_context.h View 3 chunks +2 lines, -12 lines 0 comments Download
M mojo/gpu/gl_context.cc View 3 chunks +5 lines, -7 lines 0 comments Download
D mojo/gpu/mojo_context_support.h View 1 chunk +0 lines, -41 lines 0 comments Download
D mojo/gpu/mojo_context_support.cc View 1 chunk +0 lines, -71 lines 0 comments Download
D mojo/gpu/mojo_gles2_impl_autogen.h View 1 chunk +0 lines, -758 lines 0 comments Download
D mojo/gpu/mojo_gles2_impl_autogen.cc View 1 chunk +0 lines, -1599 lines 0 comments Download
M mojo/skia/BUILD.gn View 2 chunks +16 lines, -3 lines 0 comments Download
M mojo/skia/ganesh_context.cc View 4 chunks +4 lines, -14 lines 0 comments Download
A + mojo/skia/gl_bindings_skia.h View 2 chunks +6 lines, -6 lines 0 comments Download
A + mojo/skia/gl_bindings_skia.cc View 2 chunks +13 lines, -16 lines 0 comments Download

Messages

Total messages: 4 (2 generated)
jeffbrown
TBR
5 years ago (2015-12-17 20:38:44 UTC) #2
jeffbrown
5 years ago (2015-12-17 20:40:48 UTC) #4
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
a7b1f93652cb7cecc30a46e1e160ada14397457c.

Powered by Google App Engine
This is Rietveld 408576698