Improve GL helpers.

Improve GL helpers.

Use ApplicationConnector instead of Shell to obtain an offscreen
GL context.  This makes it easier to create GL contexts from
separate threads since the Shell interface is usually owned by
the main thread.

Eagerly unbind GL textures from the context after creation to prevent
spurious circularity warnings from the GPU Service caused by textures
being bound while not actually in use.

BUG=

Review URL: https://codereview.chromium.org/1537783002 .

R=viettrungluu@chromium.org, abarth, jamesr, viettrungluu

Committed: https://chromium.googlesource.com/external/mojo/+/fb52d34d402bca2dcaeed2de5b8e4ebc691e9c8b

[viettrungluu, 2015-12-17 22:33:31]

I'm so confused.

Here's what I said on the other copy of this:

LGTM w/very minor nits.

(I'm not the expert on the unbinding part, but it seems like a good idea to me
in general.)

https://codereview.chromium.org/1537783002/diff/1/mojo/gpu/gl_context_owner.cc
File mojo/gpu/gl_context_owner.cc (right):

https://codereview.chromium.org/1537783002/diff/1/mojo/gpu/gl_context_owner.c...
mojo/gpu/gl_context_owner.cc:11:
GLContextOwner::GLContextOwner(mojo::ApplicationConnector* connector)
Ditto (here and below).

https://codereview.chromium.org/1537783002/diff/1/mojo/gpu/gl_context_owner.h
File mojo/gpu/gl_context_owner.h (right):

https://codereview.chromium.org/1537783002/diff/1/mojo/gpu/gl_context_owner.h...
mojo/gpu/gl_context_owner.h:17: explicit
GLContextOwner(mojo::ApplicationConnector* connector);
nit (pre-existing condition): "mojo::" not necessary

(whether this should just be in the mojo namespace is another question <shrug>)

[jeffbrown, 2015-12-17 22:36:35]

Sorry about that, I had an accident involving "git cl upload --dependencies" and
ended up deleting a few patches and reuploading them.

In any case, I have applied your suggested changes from the other patch.

[jeffbrown, 2016-01-26 08:57:28]

rebase

[jeffbrown, 2016-01-26 23:49:59]

Description was changed from

==========
Improve GL helpers.

Use ApplicationConnector instead of Shell to obtain an offscreen
GL context.  This makes it easier to create GL contexts from
separate threads since the Shell interface is usually owned by
the main thread.

Eagerly unbind GL textures from the context after creation to prevent
spurious circularity warnings from the GPU Service caused by textures
being bound while not actually in use.

BUG=

Review URL: https://codereview.chromium.org/1537783002 .

R=abarth, jamesr, viettrungluu
==========

to

==========
Improve GL helpers.

Use ApplicationConnector instead of Shell to obtain an offscreen
GL context.  This makes it easier to create GL contexts from
separate threads since the Shell interface is usually owned by
the main thread.

Eagerly unbind GL textures from the context after creation to prevent
spurious circularity warnings from the GPU Service caused by textures
being bound while not actually in use.

BUG=

Review URL: https://codereview.chromium.org/1537783002 .

R=viettrungluu@chromium.org, abarth, jamesr, viettrungluu

Committed:
https://chromium.googlesource.com/external/mojo/+/fb52d34d402bca2dcaeed2de5b8...
==========

[jeffbrown, 2016-01-26 23:50:00]

Committed patchset #4 (id:60001) manually as
fb52d34d402bca2dcaeed2de5b8e4ebc691e9c8b (presubmit successful).