Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Issue 1534243002: Revert of Fix UB function problems for shaders and mask. (Closed)

Created:
5 years ago by herb_g
Modified:
5 years ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Fix UB function problems for shaders and mask. (patchset #3 id:40001 of https://codereview.chromium.org/1530743002/ ) Reason for revert: Breaks man gold tests. Original issue's description: > Fix UB function problems for shaders and mask. > > BUG=skia:4634 > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1530743002 > > Committed: https://skia.googlesource.com/skia/+/dafd044e4aea529f88d899247678d4549f776388 TBR=mtklein@google.com,reed@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:4634 Committed: https://skia.googlesource.com/skia/+/1e810b3cc290b5b5d95c7789661271256288977c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -48 lines) Patch
M include/core/SkShader.h View 1 chunk +1 line, -5 lines 0 comments Download
M src/core/SkBitmapProcShader.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/core/SkBitmapProcState.h View 1 chunk +5 lines, -3 lines 0 comments Download
M src/core/SkBitmapProcState.cpp View 6 chunks +10 lines, -14 lines 0 comments Download
M src/core/SkBitmapProcState_shaderproc.h View 1 chunk +2 lines, -3 lines 0 comments Download
M src/core/SkBlitMask.h View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkBlitMask_D32.cpp View 6 chunks +18 lines, -18 lines 0 comments Download
M src/core/SkBlitter_ARGB32.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
herb_g
Created Revert of Fix UB function problems for shaders and mask.
5 years ago (2015-12-18 16:50:01 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1534243002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1534243002/1
5 years ago (2015-12-18 16:50:03 UTC) #2
commit-bot: I haz the power
5 years ago (2015-12-18 16:50:11 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/1e810b3cc290b5b5d95c7789661271256288977c

Powered by Google App Engine
This is Rietveld 408576698