Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1013)

Issue 1533613004: extract InheritedReferenceContributor from imported reference contributor (Closed)

Created:
5 years ago by danrubel
Modified:
5 years ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

extract InheritedReferenceContributor from imported reference contributor R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/3bf298760f10bb79ae34e350450889a98f8a9615

Patch Set 1 #

Patch Set 2 : include new tests in suite #

Unified diffs Side-by-side diffs Delta from patch set Stats (+964 lines, -229 lines) Patch
M pkg/analysis_server/lib/src/provisional/completion/dart/completion_plugin.dart View 2 chunks +3 lines, -0 lines 0 comments Download
A pkg/analysis_server/lib/src/services/completion/dart/inherited_reference_contributor.dart View 1 chunk +105 lines, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/local_reference_contributor.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/suggestion_builder.dart View 5 chunks +55 lines, -21 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/imported_reference_contributor.dart View 4 chunks +36 lines, -60 lines 0 comments Download
M pkg/analysis_server/test/domain_completion_test.dart View 3 chunks +32 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/services/completion/completion_test_util.dart View 1 chunk +10 lines, -13 lines 0 comments Download
M pkg/analysis_server/test/services/completion/dart/completion_contributor_util.dart View 9 chunks +55 lines, -8 lines 0 comments Download
A pkg/analysis_server/test/services/completion/dart/inherited_reference_contributor_test.dart View 1 chunk +619 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/services/completion/dart/local_reference_contributor_test.dart View 9 chunks +35 lines, -66 lines 0 comments Download
M pkg/analysis_server/test/services/completion/dart/test_all.dart View 1 2 chunks +2 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/services/completion/imported_reference_contributor_test.dart View 10 chunks +10 lines, -58 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
danrubel
5 years ago (2015-12-16 21:07:56 UTC) #2
scheglov
LGTM
5 years ago (2015-12-16 21:14:46 UTC) #3
danrubel
5 years ago (2015-12-16 21:20:56 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
3bf298760f10bb79ae34e350450889a98f8a9615 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698