Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(739)

Unified Diff: pkg/analysis_server/test/domain_completion_test.dart

Issue 1533613004: extract InheritedReferenceContributor from imported reference contributor (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: include new tests in suite Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/test/domain_completion_test.dart
diff --git a/pkg/analysis_server/test/domain_completion_test.dart b/pkg/analysis_server/test/domain_completion_test.dart
index e4f25b761179db9f9e18a5ecc21da5c79ba38818..09736bfec52757f27a375eb82b144080577f69cf 100644
--- a/pkg/analysis_server/test/domain_completion_test.dart
+++ b/pkg/analysis_server/test/domain_completion_test.dart
@@ -604,6 +604,21 @@ class CompletionTest extends AbstractAnalysisTest {
relevance: DART_RELEVANCE_LOCAL_FUNCTION);
}
+ test_inherited() {
+ addFile('/libA.dart', 'class A {m() {}}');
+ addTestFile('''
+import '/libA.dart';
+class B extends A {
+ x() {^}
+}
+''');
+ return getSuggestions().then((_) {
+ expect(replacementOffset, equals(completionOffset));
+ expect(replacementLength, equals(0));
+ assertHasResult(CompletionSuggestionKind.INVOCATION, 'm');
+ });
+ }
+
test_keyword() {
addTestFile('library A; cl^');
return getSuggestions().then((_) {
@@ -626,6 +641,22 @@ class CompletionTest extends AbstractAnalysisTest {
});
}
+ test_local_override() {
+ addFile('/libA.dart', 'class A {m() {}}');
+ addTestFile('''
+import '/libA.dart';
+class B extends A {
+ m() {}
+ x() {^}
+}
+''');
+ return getSuggestions().then((_) {
+ expect(replacementOffset, equals(completionOffset));
+ expect(replacementLength, equals(0));
+ assertHasResult(CompletionSuggestionKind.INVOCATION, 'm');
+ });
+ }
+
test_locals() {
addTestFile('class A {var a; x() {var b;^}} class DateTime { }');
return getSuggestions().then((_) {
@@ -661,8 +692,7 @@ class B extends A {m() {^}}
return getSuggestions().then((_) {
expect(replacementOffset, equals(completionOffset));
expect(replacementLength, equals(0));
- assertHasResult(CompletionSuggestionKind.INVOCATION, 'm',
- relevance: DART_RELEVANCE_LOCAL_METHOD);
+ assertHasResult(CompletionSuggestionKind.INVOCATION, 'm');
});
}

Powered by Google App Engine
This is Rietveld 408576698