Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Unified Diff: pkg/analysis_server/test/services/completion/completion_test_util.dart

Issue 1533613004: extract InheritedReferenceContributor from imported reference contributor (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: include new tests in suite Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/test/services/completion/completion_test_util.dart
diff --git a/pkg/analysis_server/test/services/completion/completion_test_util.dart b/pkg/analysis_server/test/services/completion/completion_test_util.dart
index c040b2a1b1d2d7d00113fee43220d51e0255ccf6..9ad974dff223b6405bd3d9f2c23e7ee2132fced1 100644
--- a/pkg/analysis_server/test/services/completion/completion_test_util.dart
+++ b/pkg/analysis_server/test/services/completion/completion_test_util.dart
@@ -1749,19 +1749,16 @@ abstract class AbstractSelectorSuggestionTest extends AbstractCompletionTest {
return computeFull((bool result) {
expect(request.replacementOffset, completionOffset);
expect(request.replacementLength, 0);
- // TODO (danrubel) prefer fields over getters
- // If add `get e1;` to interface I
- // then suggestions include getter e1 rather than field e1
- assertSuggestImportedField('e1', null);
- assertSuggestImportedField('f1', null);
- assertSuggestImportedField('i1', 'int');
- assertSuggestImportedField('m1', null);
- assertSuggestImportedGetter('f3', null);
- assertSuggestImportedSetter('f4');
- assertSuggestImportedMethod('e2', 'E', null);
- assertSuggestImportedMethod('f2', 'F', null);
- assertSuggestImportedMethod('i2', 'I', null);
- //assertSuggestImportedMethod('m2', null, null);
+ assertNotSuggested('e1');
+ assertNotSuggested('f1');
+ assertNotSuggested('i1');
+ assertNotSuggested('m1');
+ assertNotSuggested('f3');
+ assertNotSuggested('f4');
+ assertNotSuggested('e2');
+ assertNotSuggested('f2');
+ assertNotSuggested('i2');
+ assertNotSuggested('m2');
assertNotSuggested('==');
});
}

Powered by Google App Engine
This is Rietveld 408576698