pkg/analysis_server/lib/src/services/completion/dart/local_reference_contributor.dart - Issue 1533613004: extract InheritedReferenceContributor from imported reference contributor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/lib/src/services/completion/dart/local_reference_contributor.dart

Issue 1533613004: extract InheritedReferenceContributor from imported reference contributor (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: include new tests in suite Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/analysis_server/lib/src/services/completion/dart/inherited_reference_contributor.dart ('k') | pkg/analysis_server/lib/src/services/completion/dart/suggestion_builder.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/lib/src/services/completion/dart/local_reference_contributor.dart

diff --git a/pkg/analysis_server/lib/src/services/completion/dart/local_reference_contributor.dart b/pkg/analysis_server/lib/src/services/completion/dart/local_reference_contributor.dart

index 3d56c873792562172c17ea61c010e2e8b912eb1f..9199091a64b36e570f34386420a8f23112a61bf3 100644

--- a/pkg/analysis_server/lib/src/services/completion/dart/local_reference_contributor.dart

+++ b/pkg/analysis_server/lib/src/services/completion/dart/local_reference_contributor.dart

@@ -67,7 +67,8 @@ class _LocalVisitor extends LocalDeclarationVisitor {

bool targetIsFunctionalArgument;

_LocalVisitor(this.request, int offset, this.optype) : super(offset) {

- includeLocalInheritedTypes = !optype.inStaticMethodBody;

+ // Suggestions for inherited members provided by InheritedReferenceContributor

+ includeLocalInheritedTypes = false; // !optype.inStaticMethodBody;

targetIsFunctionalArgument = request.target.isFunctionalArgument();

// If user typed identifier starting with '_'