Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(431)

Unified Diff: pkg/analysis_server/test/services/completion/imported_reference_contributor_test.dart

Issue 1533613004: extract InheritedReferenceContributor from imported reference contributor (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: include new tests in suite Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analysis_server/test/services/completion/dart/test_all.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/test/services/completion/imported_reference_contributor_test.dart
diff --git a/pkg/analysis_server/test/services/completion/imported_reference_contributor_test.dart b/pkg/analysis_server/test/services/completion/imported_reference_contributor_test.dart
index 1b3d30f5e3ee697a5cfbcf9b41d8d65cf0a8c593..740e266b3d44454433cb16ad706355ebfa97e861 100644
--- a/pkg/analysis_server/test/services/completion/imported_reference_contributor_test.dart
+++ b/pkg/analysis_server/test/services/completion/imported_reference_contributor_test.dart
@@ -565,15 +565,7 @@ class B extends A {
}
''');
return computeFull((bool result) {
- CompletionSuggestion suggestion =
- assertSuggestImportedMethod('m', 'A', 'void');
- expect(suggestion.parameterNames, hasLength(2));
- expect(suggestion.parameterNames[0], 'x');
- expect(suggestion.parameterTypes[0], 'dynamic');
- expect(suggestion.parameterNames[1], 'y');
- expect(suggestion.parameterTypes[1], 'int');
- expect(suggestion.requiredParameterCount, 1);
- expect(suggestion.hasNamedParameters, true);
+ assertNotSuggested('m');
});
}
@@ -592,15 +584,7 @@ class B extends A {
}
''');
return computeFull((bool result) {
- CompletionSuggestion suggestion =
- assertSuggestImportedMethod('m', 'A', 'void');
- expect(suggestion.parameterNames, hasLength(2));
- expect(suggestion.parameterNames[0], 'x');
- expect(suggestion.parameterTypes[0], 'dynamic');
- expect(suggestion.parameterNames[1], 'y');
- expect(suggestion.parameterTypes[1], 'int');
- expect(suggestion.requiredParameterCount, 1);
- expect(suggestion.hasNamedParameters, false);
+ assertNotSuggested('m');
});
}
@@ -619,15 +603,7 @@ class B extends A {
}
''');
return computeFull((bool result) {
- CompletionSuggestion suggestion =
- assertSuggestImportedMethod('m', 'A', 'void');
- expect(suggestion.parameterNames, hasLength(2));
- expect(suggestion.parameterNames[0], 'x');
- expect(suggestion.parameterTypes[0], 'dynamic');
- expect(suggestion.parameterNames[1], 'y');
- expect(suggestion.parameterTypes[1], 'int');
- expect(suggestion.requiredParameterCount, 0);
- expect(suggestion.hasNamedParameters, true);
+ assertNotSuggested('m');
});
}
@@ -647,12 +623,7 @@ class B extends A {
''');
computeFast();
return computeFull((bool result) {
- CompletionSuggestion suggestion =
- assertSuggestImportedMethod('m', 'A', 'void');
- expect(suggestion.parameterNames, isEmpty);
- expect(suggestion.parameterTypes, isEmpty);
- expect(suggestion.requiredParameterCount, 0);
- expect(suggestion.hasNamedParameters, false);
+ assertNotSuggested('m');
});
}
@@ -671,15 +642,7 @@ class B extends A {
}
''');
return computeFull((bool result) {
- CompletionSuggestion suggestion =
- assertSuggestImportedMethod('m', 'A', 'void');
- expect(suggestion.parameterNames, hasLength(2));
- expect(suggestion.parameterNames[0], 'x');
- expect(suggestion.parameterTypes[0], 'dynamic');
- expect(suggestion.parameterNames[1], 'y');
- expect(suggestion.parameterTypes[1], 'int');
- expect(suggestion.requiredParameterCount, 0);
- expect(suggestion.hasNamedParameters, false);
+ assertNotSuggested('m');
});
}
@@ -698,15 +661,7 @@ class B extends A {
}
''');
return computeFull((bool result) {
- CompletionSuggestion suggestion =
- assertSuggestImportedMethod('m', 'A', 'void');
- expect(suggestion.parameterNames, hasLength(2));
- expect(suggestion.parameterNames[0], 'x');
- expect(suggestion.parameterTypes[0], 'dynamic');
- expect(suggestion.parameterNames[1], 'y');
- expect(suggestion.parameterTypes[1], 'int');
- expect(suggestion.requiredParameterCount, 2);
- expect(suggestion.hasNamedParameters, false);
+ assertNotSuggested('m');
});
}
@@ -731,7 +686,7 @@ class C extends B with M1, M2 {
}
''');
return computeFull((bool result) {
- assertSuggestImportedMethod('m', 'M2', 'void');
+ assertNotSuggested('m');
});
}
@@ -798,8 +753,7 @@ class B extends A {
}
''');
return computeFull((bool result) {
- CompletionSuggestion suggestion = assertSuggestImportedField('x', 'int');
- assertHasNoParameterInfo(suggestion);
+ assertNotSuggested('x');
});
}
@@ -818,8 +772,7 @@ class B extends A {
}
''');
return computeFull((bool result) {
- CompletionSuggestion suggestion = assertSuggestImportedGetter('x', 'int');
- assertHasNoParameterInfo(suggestion);
+ assertNotSuggested('x');
});
}
@@ -838,8 +791,7 @@ class B extends A {
}
''');
return computeFull((bool result) {
- CompletionSuggestion suggestion = assertSuggestImportedSetter('x');
- assertHasNoParameterInfo(suggestion);
+ assertNotSuggested('x');
});
}
« no previous file with comments | « pkg/analysis_server/test/services/completion/dart/test_all.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698