Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 1528873002: VM: Use read-only handle Object::dynamic_type() where possible. (Closed)

Created:
5 years ago by Florian Schneider
Modified:
5 years ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

VM: Use read-only handle Object::dynamic_type() where possible. BUG= R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/4a037f0ccb6eeb72ca47c47d21d87d8ed9cca2f3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -68 lines) Patch
M runtime/vm/ast.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/ast_transformer.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/compiler.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/constant_propagator.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/flow_graph_builder.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M runtime/vm/flow_graph_compiler_arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/flow_graph_compiler_arm64.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/flow_graph_compiler_ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/flow_graph_compiler_mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/flow_graph_compiler_x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/flow_graph_optimizer.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/flow_graph_type_propagator.cc View 5 chunks +9 lines, -9 lines 0 comments Download
M runtime/vm/intrinsifier_ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/parser.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/parser.cc View 34 chunks +34 lines, -33 lines 0 comments Download
M runtime/vm/regexp.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M runtime/vm/regexp_assembler_ir.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M runtime/vm/scopes.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Florian Schneider
5 years ago (2015-12-15 13:22:35 UTC) #2
siva
STV
5 years ago (2015-12-16 01:09:42 UTC) #3
siva
lgtm
5 years ago (2015-12-16 01:09:50 UTC) #4
siva
lgtm
5 years ago (2015-12-16 01:09:51 UTC) #5
Florian Schneider
5 years ago (2015-12-16 10:31:59 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4a037f0ccb6eeb72ca47c47d21d87d8ed9cca2f3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698