Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(557)

Side by Side Diff: runtime/vm/regexp_assembler_ir.cc

Issue 1528873002: VM: Use read-only handle Object::dynamic_type() where possible. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/vm/regexp.cc ('k') | runtime/vm/scopes.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/regexp_assembler_ir.h" 5 #include "vm/regexp_assembler_ir.h"
6 6
7 #include "vm/bit_vector.h" 7 #include "vm/bit_vector.h"
8 #include "vm/compiler.h" 8 #include "vm/compiler.h"
9 #include "vm/dart_entry.h" 9 #include "vm/dart_entry.h"
10 #include "vm/flow_graph_builder.h" 10 #include "vm/flow_graph_builder.h"
(...skipping 364 matching lines...) Expand 10 before | Expand all | Expand 10 after
375 } 375 }
376 376
377 377
378 DEFINE_RAW_LEAF_RUNTIME_ENTRY( 378 DEFINE_RAW_LEAF_RUNTIME_ENTRY(
379 CaseInsensitiveCompareUC16, 4, false /* is_float */, 379 CaseInsensitiveCompareUC16, 4, false /* is_float */,
380 reinterpret_cast<RuntimeFunction>(&CaseInsensitiveCompareUC16)); 380 reinterpret_cast<RuntimeFunction>(&CaseInsensitiveCompareUC16));
381 381
382 382
383 LocalVariable* IRRegExpMacroAssembler::Parameter(const String& name, 383 LocalVariable* IRRegExpMacroAssembler::Parameter(const String& name,
384 intptr_t index) const { 384 intptr_t index) const {
385 const Type& local_type = Type::ZoneHandle(Z, Type::DynamicType());
386 LocalVariable* local = 385 LocalVariable* local =
387 new(Z) LocalVariable(kNoSourcePos, name, local_type); 386 new(Z) LocalVariable(kNoSourcePos, name, Object::dynamic_type());
388 387
389 intptr_t param_frame_index = kParamEndSlotFromFp + kParamCount - index; 388 intptr_t param_frame_index = kParamEndSlotFromFp + kParamCount - index;
390 local->set_index(param_frame_index); 389 local->set_index(param_frame_index);
391 390
392 return local; 391 return local;
393 } 392 }
394 393
395 394
396 LocalVariable* IRRegExpMacroAssembler::Local(const String& name) { 395 LocalVariable* IRRegExpMacroAssembler::Local(const String& name) {
397 const Type& local_type = Type::ZoneHandle(Z, Type::DynamicType());
398 LocalVariable* local = 396 LocalVariable* local =
399 new(Z) LocalVariable(kNoSourcePos, name, local_type); 397 new(Z) LocalVariable(kNoSourcePos, name, Object::dynamic_type());
400 local->set_index(GetNextLocalIndex()); 398 local->set_index(GetNextLocalIndex());
401 399
402 return local; 400 return local;
403 } 401 }
404 402
405 403
406 ConstantInstr* IRRegExpMacroAssembler::Int64Constant(int64_t value) const { 404 ConstantInstr* IRRegExpMacroAssembler::Int64Constant(int64_t value) const {
407 return new(Z) ConstantInstr( 405 return new(Z) ConstantInstr(
408 Integer::ZoneHandle(Z, Integer::New(value, Heap::kOld))); 406 Integer::ZoneHandle(Z, Integer::New(value, Heap::kOld)));
409 } 407 }
(...skipping 1516 matching lines...) Expand 10 before | Expand all | Expand 10 after
1926 index_val, 1924 index_val,
1927 characters, 1925 characters,
1928 specialization_cid_, 1926 specialization_cid_,
1929 Scanner::kNoSourcePos)); 1927 Scanner::kNoSourcePos));
1930 } 1928 }
1931 1929
1932 1930
1933 #undef __ 1931 #undef __
1934 1932
1935 } // namespace dart 1933 } // namespace dart
OLDNEW
« no previous file with comments | « runtime/vm/regexp.cc ('k') | runtime/vm/scopes.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698