runtime/vm/flow_graph_compiler_x64.cc - Issue 1528873002: VM: Use read-only handle Object::dynamic_type() where possible.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/flow_graph_compiler_x64.cc

Issue 1528873002: VM: Use read-only handle Object::dynamic_type() where possible. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/flow_graph_compiler_x64.cc

diff --git a/runtime/vm/flow_graph_compiler_x64.cc b/runtime/vm/flow_graph_compiler_x64.cc

index 42b3677bc82c3adf48a372fd084373708321f716..608e74da6e180a46bc6427cf15e3c8712405a29a 100644

--- a/runtime/vm/flow_graph_compiler_x64.cc

+++ b/runtime/vm/flow_graph_compiler_x64.cc

@@ -461,7 +461,7 @@ RawSubtypeTestCache* FlowGraphCompiler::GenerateUninstantiatedTypeTest(

FieldAddress(RDX, TypeArguments::type_at_offset(type_param.index())));

// RDI: Concrete type of type.

// Check if type argument is dynamic.

- __ CompareObject(RDI, Type::ZoneHandle(zone(), Type::DynamicType()));

+ __ CompareObject(RDI, Object::dynamic_type());

__ j(EQUAL, is_instance_lbl);

const Type& object_type = Type::ZoneHandle(zone(), Type::ObjectType());

__ CompareObject(RDI, object_type);

« no previous file with comments | « runtime/vm/flow_graph_compiler_mips.cc ('k') | runtime/vm/flow_graph_optimizer.cc » ('j') | no next file with comments »