runtime/vm/flow_graph_compiler_arm.cc - Issue 1528873002: VM: Use read-only handle Object::dynamic_type() where possible.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/flow_graph_compiler_arm.cc

Issue 1528873002: VM: Use read-only handle Object::dynamic_type() where possible. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/flow_graph_compiler_arm.cc

diff --git a/runtime/vm/flow_graph_compiler_arm.cc b/runtime/vm/flow_graph_compiler_arm.cc

index a11916db9e64fb4dc09567874900d56c39d8a174..21beeb04b30c2d41481b3875a438957212ea0f46 100644

--- a/runtime/vm/flow_graph_compiler_arm.cc

+++ b/runtime/vm/flow_graph_compiler_arm.cc

@@ -460,7 +460,7 @@ RawSubtypeTestCache* FlowGraphCompiler::GenerateUninstantiatedTypeTest(

FieldAddress(R1, TypeArguments::type_at_offset(type_param.index())));

// R2: concrete type of type.

// Check if type argument is dynamic.

- __ CompareObject(R2, Type::ZoneHandle(zone(), Type::DynamicType()));

+ __ CompareObject(R2, Object::dynamic_type());

__ b(is_instance_lbl, EQ);

__ CompareObject(R2, Type::ZoneHandle(zone(), Type::ObjectType()));

__ b(is_instance_lbl, EQ);

« no previous file with comments | « runtime/vm/flow_graph_builder.cc ('k') | runtime/vm/flow_graph_compiler_arm64.cc » ('j') | no next file with comments »