runtime/vm/flow_graph_optimizer.cc - Issue 1528873002: VM: Use read-only handle Object::dynamic_type() where possible.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/flow_graph_optimizer.cc

Issue 1528873002: VM: Use read-only handle Object::dynamic_type() where possible. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/flow_graph_optimizer.cc

diff --git a/runtime/vm/flow_graph_optimizer.cc b/runtime/vm/flow_graph_optimizer.cc

index 15642fc572354989384a57e0bbdda11ce3c1d502..6624b07f231ee7c810c2b1c4fc47032dbbcea63e 100644

--- a/runtime/vm/flow_graph_optimizer.cc

+++ b/runtime/vm/flow_graph_optimizer.cc

@@ -1726,7 +1726,7 @@ intptr_t FlowGraphOptimizer::PrepareInlineIndexedOp(Instruction* call,

new(Z) LoadFieldInstr(

new(Z) Value(*array),

GrowableObjectArray::data_offset(),

- Type::ZoneHandle(Z, Type::DynamicType()),

+ Object::dynamic_type(),

call->token_pos());

elements->set_result_cid(kArrayCid);

*cursor = flow_graph()->AppendTo(*cursor,

« no previous file with comments | « runtime/vm/flow_graph_compiler_x64.cc ('k') | runtime/vm/flow_graph_type_propagator.cc » ('j') | no next file with comments »