Make base a static ibrary

Make base a static ibrary

This saves a nontrivial amount of space for some of the smaller targets in release builds. See the comment added to the base target for more.

Remove libmojo_sdk. This is a complete static library that depended on base. Since base is now a static library, this dependency is not allowed. The mojo team says this target is no longer needed, so it was deleted.

Committed: https://crrev.com/89c7be623e3cc5052aaf8c3be3996432a9d4bceb
Cr-Commit-Position: refs/heads/master@{#365955}

[brettw, 2015-12-16 00:29:21]

brettw@chromium.org changed reviewers:
+ dpranke@chromium.org

[brettw, 2015-12-16 00:29:25]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-16 00:30:02]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1528233002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1528233002/1

[Dirk Pranke, 2015-12-16 00:32:06]

lgtm

[commit-bot: I haz the power, 2015-12-16 02:40:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-16 02:40:57]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_android_rel_ng on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)

[brettw, 2015-12-16 16:42:07]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2015-12-16 16:43:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1528233002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1528233002/1

[commit-bot: I haz the power, 2015-12-16 17:11:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-16 17:11:53]

Try jobs failed on following builders:
  linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[brettw, 2015-12-16 19:11:18]

base_paths for nacl

[brettw, 2015-12-16 19:11:33]

The CQ bit was checked by brettw@chromium.org

[brettw, 2015-12-16 19:11:33]

The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org
Link to the patchset: https://codereview.chromium.org/1528233002/#ps20001
(title: "base_paths for nacl")

[commit-bot: I haz the power, 2015-12-16 19:12:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1528233002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1528233002/20001

[commit-bot: I haz the power, 2015-12-16 19:49:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-16 19:49:59]

Try jobs failed on following builders:
  linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[brettw, 2015-12-16 20:05:49]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2015-12-16 20:07:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1528233002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1528233002/20001

[commit-bot: I haz the power, 2015-12-16 20:55:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-16 20:55:11]

Try jobs failed on following builders:
  linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[brettw, 2015-12-17 23:22:18]

The CQ bit was checked by brettw@chromium.org

[brettw, 2015-12-17 23:22:18]

The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org
Link to the patchset: https://codereview.chromium.org/1528233002/#ps40001
(title: " ")

[commit-bot: I haz the power, 2015-12-17 23:25:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1528233002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1528233002/40001

[commit-bot: I haz the power, 2015-12-18 01:07:46]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-12-18 01:08:44]

Description was changed from

==========
Make base a static ibrary

This saves a nontrivial amount of space for some of the smaller targets in
release builds. See the comment added to the base target for more.

Remove libmojo_sdk. This is a complete static library that depended on base.
Since base is now a static library, this dependency is not allowed. The mojo
team says this target is no longer needed, so it was deleted.
==========

to

==========
Make base a static ibrary

This saves a nontrivial amount of space for some of the smaller targets in
release builds. See the comment added to the base target for more.

Remove libmojo_sdk. This is a complete static library that depended on base.
Since base is now a static library, this dependency is not allowed. The mojo
team says this target is no longer needed, so it was deleted.

Committed: https://crrev.com/89c7be623e3cc5052aaf8c3be3996432a9d4bceb
Cr-Commit-Position: refs/heads/master@{#365955}
==========

[commit-bot: I haz the power, 2015-12-18 01:08:45]

Patchset 3 (id:??) landed as
https://crrev.com/89c7be623e3cc5052aaf8c3be3996432a9d4bceb
Cr-Commit-Position: refs/heads/master@{#365955}

[phoglund_chromium, 2015-12-18 09:22:44]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/1532953003/ by phoglund@chromium.org.

The reason for reverting is: Breaks Win GN link: 

unresolved external symbol JSONFileValueDeserializer::JSONFileValueDeserializer
... referenced in function "class JsonPrefStore::ReadResult> > __cdecl
`anonymous namespace'::ReadPrefsFromDisk ...

https://build.chromium.org/p/chromium.win/builders/Win%20x64%20GN%20%28dbg%29....