Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4089)

Unified Diff: base/debug/BUILD.gn

Issue 1528233002: Make base a static ibrary (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/BUILD.gn ('k') | base/json/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/debug/BUILD.gn
diff --git a/base/debug/BUILD.gn b/base/debug/BUILD.gn
index a910d96b4a107a08d2b199b06633e0342248771f..eb2a3097332f274726a2852907a4bc37e1aa0310 100644
--- a/base/debug/BUILD.gn
+++ b/base/debug/BUILD.gn
@@ -5,7 +5,8 @@
import("//build/buildflag_header.gni")
import("//build/config/compiler/compiler.gni")
-source_set("debug") {
+# Should be static library, see documentation on //base:base for discussion.
+static_library("debug") {
sources = [
"alias.cc",
"alias.h",
« no previous file with comments | « base/BUILD.gn ('k') | base/json/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698