base/third_party/dynamic_annotations/BUILD.gn - Issue 1528233002: Make base a static ibrary

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/third_party/dynamic_annotations/BUILD.gn

Issue 1528233002: Make base a static ibrary (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/third_party/dynamic_annotations/BUILD.gn

diff --git a/base/third_party/dynamic_annotations/BUILD.gn b/base/third_party/dynamic_annotations/BUILD.gn

index 86f6558401a19c92c0068c728d44489485cb09a7..0fc4bf740818d64c05962db04eeaaf9fc2bbffbe 100644

--- a/base/third_party/dynamic_annotations/BUILD.gn

+++ b/base/third_party/dynamic_annotations/BUILD.gn

@@ -12,7 +12,8 @@ if (is_nacl) {

]

}

} else {

- source_set("dynamic_annotations") {

+ # Should be static library, see documentation on //base:base for discussion.

+ static_library("dynamic_annotations") {

sources = [

"../valgrind/valgrind.h",

"dynamic_annotations.c",

« no previous file with comments | « base/process/BUILD.gn ('k') | base/trace_event/BUILD.gn » ('j') | no next file with comments »