sandbox/win/BUILD.gn - Issue 1528233002: Make base a static ibrary

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sandbox/win/BUILD.gn

Issue 1528233002: Make base a static ibrary (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sandbox/win/BUILD.gn

diff --git a/sandbox/win/BUILD.gn b/sandbox/win/BUILD.gn

index 4d1dd58b26d6ec42f8cd10615295a097226f4712..327396b5d16c0c7933d3fc1161648b3cc34a7df0 100644

--- a/sandbox/win/BUILD.gn

+++ b/sandbox/win/BUILD.gn

@@ -4,7 +4,11 @@

import("//testing/test.gni")

-source_set("sandbox") {

+# This needs to be a static library rather than a sources set because small

+# portions of this are used in some contexts (like chrome_elf), and it

+# doesnn't seem to dead-code strip very well. This saves 12K on chrome_elf.dll,

+# over a source set, for example.

+static_library("sandbox") {

sources = [

"src/acl.cc",

"src/acl.h",

« no previous file with comments | « mojo/public/BUILD.gn ('k') | no next file » | no next file with comments »